Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Riverlea extension (*not* theme) + dark mode on new Standalone installs #31633

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ufundo
Copy link
Contributor

@ufundo ufundo commented Dec 19, 2024

Overview

Enables Riverlea extension in the Standalone install process + set the starting dark mode to Inherit from browser/OS.

Note this does not select a Riverlea theme by default - but they will be available in the theme options in display settings.

Before

  • default for Riverlea dark mode has been switched to Always light to avoid conflicts with CMS themes
  • Two steps required to use Riverlea ( enable the extension, then select a theme )
  • Standalone will be Always light by default

After

  • Only one step to use Riverlea on Standalone ( go to Display Settings and pick one)
  • Standalone will Inherit [dark mode] from browser/os by default

Technical Details

The slight risk of this would be if any of the Riverlea extension hooks caused problems when the extension was installed but a Riverlea theme wasn't selected. There were a couple of issues like this early on, but I think these have been ironed out now.

Copy link

civibot bot commented Dec 19, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Dec 19, 2024
@ufundo ufundo marked this pull request as ready for review December 19, 2024 12:43
@colemanw colemanw merged commit 8c386bf into civicrm:master Dec 19, 2024
1 check passed
@ufundo ufundo deleted the standalone-allow-dark-mode branch December 19, 2024 16:31
@ufundo
Copy link
Contributor Author

ufundo commented Dec 19, 2024

Thanks @colemanw

I think we need a few more Star Wars Dark Side references in the Standalone/Riverlea marketing material!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants