Riverlea - disable dark mode by default

[ufundo]

Overview

Lots of CMSes don't like dark mode, so disable it by default in Riverlea. See civicrm/civicrm-buildkit#901

Before

• default is inherit (ie respect your browser/OS's dark mode setting)
• if your CMS theme doesn't support dark mode, then liable to clashes that dont look good

After

• default is light (never use dark mode)
• you can switch it to inherit (or dark) in Display Settings or in Riverlea Settings

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[colemanw]

Lots of CMSes don't like dark mode

We could make an exception for standalone?

[ufundo]

Yes, I think that would be next step

[demeritcowboy]

I don't normally look at theming stuff but anything that turns off dark mode is The Right Thing To Do™

[ufundo]

@colemanw follow up #31633

[ufundo]

Thanks @demeritcowboy . Standalone might go over to the Dark Side though still 👿

[ufundo]

I'm thinking this should probably be backported to 5.81 and maybe even 5.80.

@totten any view on this?

[ufundo]

@totten PRs if you think it makes sense. Feel free to take em or leave em!
#31643
#31644

[kcristiano]

@ufundo I do think this should be in 5.81, I don't think it's worth a backport to 5.80 unless we are already planning a release.