Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Build tetragon on Windows (Part -1) #3445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ExceptionalHandler
Copy link

@ExceptionalHandler ExceptionalHandler commented Feb 27, 2025

Description

Originally was #3440
This change attempts to build tetragon on Windows. Following is the strategy

1. Code that is used in both platform, but is different, is separated by _linux.go and _windows.go suffixes.
2. Some packages now therefore have three go files seperating common, linux and windows code
3. the _windows.go files will be in a separate PR
4. Code that is unique to each OS is compiled with approrpiate //go:build directive
5. Certain constants are moved to a separate constants package

Caveats

This is a compilation change to prepare for Windows build. This does not compile on Windows.

Changelog

Add build markers and suffixes for Linux specific code

@ExceptionalHandler ExceptionalHandler requested a review from a team as a code owner February 27, 2025 22:23
Following is the strategy
1. Code that is used in both platform, but is different, is separated by _linux.go and _windows.go suffixes.
2. Some packages now therefore have three go files separating common, linux and windows code
3. the _windows.go files will be in a separate PR
4. Code that is unique to each OS is compiled with approrpriate //go:build directive
5. Certain constants are moved to a separate constants package

Signed-off-by: Anadi Anadi <aanadi@cisco.com>
@ExceptionalHandler
Copy link
Author

Closing this and re-opening #3440

@ExceptionalHandler
Copy link
Author

Reopening as #3440 Cannot be reopened.

@mtardy mtardy closed this Feb 28, 2025
@mtardy mtardy reopened this Feb 28, 2025
@mtardy
Copy link
Member

mtardy commented Feb 28, 2025

So we can't reopen the previous PR because the original branch was overwritten here unfortunately, here's the old PR for history and comments #3440.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants