-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Build tetragon on Windows #3440
Conversation
293f844
to
c88e839
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Anadi thanks for that massive amount of work! 🪟
What would you thinkk about maybe splitting this into different commits for example:
- commits for build directive/renaming _linux _windows
- many multiple commits for logical changes that were needed in the codebase
@mtardy , That was the original plan, but the logical changes turned out to be minimal and restricted to only seven files. We needed those to build on Windows. Most changes are addition of |
heya,
thanks |
+1 @mtardy .. I think it should be still possible to move the changes into several separate parts, does not need to be commit per package, but bigger some bigger commits granularity would ease the review |
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…trategy 1. Code that is used in both platform, but is different, is separated by _linux.go and _windows.go suffixes. 2. Some packages now therefore have three go files seperating common, linux and windows code 3. the _windows.go files will be in a separate PR 4. Code that is unique to each OS is compiled with approrpiate //go:build directive 5. Certain constants are moved to a separate constants package Signed-off-by: Anadi Anadi <aanadi@cisco.com>
44f9642
to
779a1f1
Compare
Closing this PR. |
hey, you could rebase so that we have the history of the discussion in the same PR. You can use |
Description
This change attempts to build tetragon on Windows. Following is the strategy
Caveats:
This is a compilation change. Tetragon.exe on windows runs and shows help message but does not monitor any activity.
Changelog