rename debug #2657
Merged
rename debug #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brrmorre
commented
Oct 8, 2020
| @@ -132,19 +132,14 @@ trait HasPeripheryDebugModuleImp extends LazyModuleImp { | |||
| c:= io.clock | |||
| r:= io.reset | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
unnecessary formatting changes I should get rid of these
jackkoenig
reviewed
Oct 8, 2020
jackkoenig
reviewed
Oct 8, 2020
Comment on lines
128
to
130
| debug.clockeddmi.foreach { | ||
| val outerdebug = outer.debugOpt.get | ||
| dbg => outerdebug.module.io.dmi.get <> dbg } |
There was a problem hiding this comment.
Suggested change
| debug.clockeddmi.foreach { | |
| val outerdebug = outer.debugOpt.get | |
| dbg => outerdebug.module.io.dmi.get <> dbg } | |
| val outerdebug = outer.debugOpt.get | |
| debug.clockeddmi.foreach { dbg => outerdebug.module.io.dmi.get <> dbg } |
There was a problem hiding this comment.
outerdebug is needed below
brrmorre
force-pushed
the
brrmorre-rename-debug
branch
from
2355117 to
f12166f
Compare
jackkoenig
force-pushed
the
brrmorre-rename-debug
branch
from
43218d5 to
f05f772
Compare
hcook
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: bug report | feature request | other enhancement
Impact: no functional change | API addition (no impact on existing code) | API modification
Development Phase: proposal | implementation
Release Notes