Moving tool installation to step prior to matrix generation #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From verilator: Warns that the lifetime of a task or a function was not provided and so was implicitly set to static. The warning is suppressed when no variables inside the task or a function are assigned to.
calebofearth
reviewed
May 3, 2023
There was a problem hiding this comment.
Two requests:
(1) Let's file an Issue regarding upgrade to Verilator 5.010 (or later if available)
(2) Can we add a result checker for the Verilator Workflow? See #71 for recommendations.
|
calebofearth
approved these changes
May 3, 2023
mkurc-ant
reviewed
May 4, 2023
mkurc-ant
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving tool installation to step prior to matrix generation.
If the tools haven't been cached in a new branch, each test will clobber the cache, causing the tests to install the tools every time. This re-arranges the order so that we ensure tools are installed prior to creating the test matrix.
This also modified the watchdog timer from always_comb to generate as discussed in #71