-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gha: verilator: Add '--locked' to sccache install #559
gha: verilator: Add '--locked' to sccache install #559
Conversation
Cool! I had just updated the SCCACHE version to 0.8.1 to get around this in my other PR, which also solves the issue. |
88c53e0
to
18f2654
Compare
Thanks for a quick reply!
None that I know of. |
Use exact crate versions specified by Cargo.lock. Signed-off-by: Wiktoria Kuna <wkuna@antmicro.com>
18f2654
to
3f3473c
Compare
Ah, looks like there's another workflow issue. You'll need to add
in pull_request.yml for the doc_gen job. |
Signed-off-by: Wiktoria Kuna <wkuna@antmicro.com>
@wkkuna Thanks for the updates. |
Just had to rerun the job to get the compile.yml check to pass. |
@calebofearth Ran the script locally and committed new hashes. |
Looks like the committed hash is incorrect. Do you have local file modifications where you checked out this branch? |
The changes apply only to the github workflow flow, simulate a pass from internal workflow. Signed-off-by: Wiktoria Kuna <wkuna@antmicro.com>
ddba9f7
to
9456391
Compare
Sorry, I didn't realize. Checked |
Having run a workflow (first time in a while) in the fork repository I noticed the
Install sccache
step fail to compilegha-toolkit
.Link to failed workflow log: https://github.com/antmicro/caliptra-rtl/actions/runs/10059008558/job/27805130656
Adding
--locked
flag tocargo install
ensures the crates used to build thesccache
are exactly those that are specified byCargo.lock
.The tool build log with
--locked
flag (note: this workflow may fail as I'm currently testing a new feature in the github flow): https://github.com/antmicro/caliptra-rtl/actions/runs/10072642584/job/27844989866#step:5:1