Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upload] [Accessibility] Add aria-live polite to Alerts #567

Closed
shindigira opened this issue May 23, 2024 · 0 comments · Fixed by #587
Closed

[Upload] [Accessibility] Add aria-live polite to Alerts #567

shindigira opened this issue May 23, 2024 · 0 comments · Fixed by #587
Assignees
@shindigira
Labels
UI Tasks involving visual elements

Comments

@shindigira
Copy link
Contributor

shindigira commented May 23, 2024 •
edited
Loading

keyboard accessibility?
@shindigira shindigira added the UI Tasks involving visual elements label May 23, 2024
@shindigira shindigira self-assigned this May 23, 2024
This was referenced May 28, 2024
Merged
Closed
Merged
shindigira added a commit to cfpb/design-system-react that referenced this issue May 31, 2024
@shindigira @meissadia
chore(DS): twitter icon now changes to x icon, deps(DS): Updated DS p…
5498b42 
…ackages -- Including Icons (#361)

closes #362

## Changes
- ~~accessibility(Alert, FieldLeveLAlert): adds aria-live region
handling~~
- deps(DS): Updated @cfpb/cfpb-icons to latest
- chore(DS): twitter icon now changes to x icon


## Screenshot
<img width="825" alt="Screenshot 2024-05-28 at 2 37 08 PM"
src="https://github.com/cfpb/design-system-react/assets/13324863/8c65fb4c-9fb2-4dd3-8289-974b70ebe291">


Related: cfpb/sbl-frontend#567

---------

Co-authored-by: Meis <meissadia@gmail.com>
shindigira added a commit that referenced this issue Jun 1, 2024
@shindigira
[Upload] alerts accessibility, Twitter icon ---> X icon (#587)
7605eab 
closes #588 
closes #567 

## Changes
- enhancement(Upload) - error alerts receive `aria-live` polite
- enhancement(Footer) - Twitter icon ---> X icon

Relies on cfpb/design-system-react#361 being
merged in to receive the cfpb icon update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shindigira shindigira

Labels
UI Tasks involving visual elements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Upload] alerts accessibility, Twitter icon ---> X icon cfpb/sbl-frontend
1 participant
@shindigira