chore(DS): twitter icon now changes to x icon, deps(DS): Updated DS packages -- Including Icons #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shindigira
changed the title
billhimmelsbach
requested changes
May 30, 2024
shindigira
changed the title
|
@billhimmelsbach Removed the default |
billhimmelsbach
approved these changes
May 31, 2024
billhimmelsbach
requested changes
May 31, 2024
…tem-react into 360-accessibility-alerts
shindigira
added a commit
to cfpb/sbl-frontend
that referenced
this pull request
Jun 1, 2024
closes #588 closes #567 ## Changes - enhancement(Upload) - error alerts receive `aria-live` polite - enhancement(Footer) - Twitter icon ---> X icon Relies on cfpb/design-system-react#361 being merged in to receive the cfpb icon update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #362
Changes
accessibility(Alert, FieldLeveLAlert): adds aria-live region handlingScreenshot
Related: cfpb/sbl-frontend#567