service/block: Remove block fetching capability from BlockService

CHANGELOG-PENDING.md

@@ -15,6 +15,7 @@ Month, DD, YYYY
 ### IMPROVEMENTS
 
 - [go package] (Link to PR) Description @username
+- [services/block: Remove block fetching capability from `BlockService`](https://github.com/celestiaorg/celestia-node/pull/277) [@renaynay](https://github.com/renaynay) 
 
 ### BUG FIXES
 

node/components.go

@@ -19,7 +19,7 @@ func lightComponents(cfg *Config, repo Repository) fx.Option {
 	)
 }
 
-// fullComponents keeps all the components as DI options required to built a Full Node.
+// fullComponents keeps all the components as DI options required to build a Full Node.
 func fullComponents(cfg *Config, repo Repository) fx.Option {
 	return fx.Options(
 		baseComponents(cfg, repo),

node/full_test.go

@@ -99,7 +99,6 @@ func TestFull_P2P_Streams(t *testing.T) {
 
 func TestFull_WithRemoteCore(t *testing.T) {
 	// TODO(@Wondertan): Fix core
-	t.Skip("Skip until we fix core")
 
 	repo := MockRepository(t, DefaultConfig(Full))
 	remoteCore, protocol, ip := core.StartRemoteCore()
@@ -126,26 +125,6 @@ func TestFull_WithRemoteCore(t *testing.T) {
 	require.NoError(t, err)
 }
 
-func TestFull_WithRemoteCoreFailed(t *testing.T) {
-	repo := MockRepository(t, DefaultConfig(Full))
-	remoteCore, protocol, ip := core.StartRemoteCore()
-	require.NotNil(t, remoteCore)
-	assert.True(t, remoteCore.IsRunning())
-
-	node, err := New(Full, repo, WithRemoteCore(protocol, ip))
-	require.NoError(t, err)
-	require.NotNil(t, node)
-
-	ctx, cancel := context.WithCancel(context.Background())
-	t.Cleanup(cancel)
-
-	err = node.CoreClient.Stop()
-	require.NoError(t, err)
-
-	err = node.Start(ctx)
-	require.Error(t, err, "node: failed to start: client not running")
-}
-
 func TestFull_NotPanicWithNilOpts(t *testing.T) {
 	repo := MockRepository(t, DefaultConfig(Full))
 	node, err := New(Full, repo, nil)

node/services/service.go

@@ -11,7 +11,6 @@ import (
 	pubsub "github.com/libp2p/go-libp2p-pubsub"
 	"go.uber.org/fx"
 
-	"github.com/celestiaorg/celestia-node/core"
 	"github.com/celestiaorg/celestia-node/das"
 	"github.com/celestiaorg/celestia-node/node/fxutil"
 	"github.com/celestiaorg/celestia-node/service/block"
@@ -78,11 +77,9 @@ func HeaderStore(ds datastore.Batching) (header.Store, error) {
 // BlockService constructs new block.Service.
 func BlockService(
 	lc fx.Lifecycle,
-	fetcher *core.BlockFetcher,
 	store ipld.DAGService,
-	broadcaster header.Broadcaster,
 ) *block.Service {
-	service := block.NewBlockService(fetcher, store, broadcaster)
+	service := block.NewBlockService(store)
 	lc.Append(fx.Hook{
 		OnStart: service.Start,
 		OnStop:  service.Stop,