Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/block: Remove block fetching capability from BlockService #277

Closed
wants to merge 3 commits into from

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Dec 8, 2021

This PR is the first step necessary to resolve #251 (it resolves the first TODO).

@renaynay renaynay added no_changelog area:block Raw blocks and erasure coded blocks labels Dec 8, 2021
@Wondertan
Copy link
Member

Btw, there should be a changelog entry for this one.

@renaynay renaynay self-assigned this Dec 10, 2021
@Wondertan
Copy link
Member

@adlerjohn, note that this PR is a part of a bigger goal and changes here might not make sense in isolation

@adlerjohn
Copy link
Member

@Wondertan I gathered that much 😂. So long as the noted peculiarities are expected I have no issue with them temporarily existing.

@renaynay renaynay requested a review from adlerjohn December 20, 2021 15:14
@@ -0,0 +1,38 @@
package utils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why utils?

I like the approach of making things reusable but in a modular domain-specific way, not a monolithic way. And we are already going with the former.

The latter:
services/
header_service.go
share_service.go

The former:
header/
service.go
share/
service.go

Same with utils. Having one big folder for all the utils is monolithic and prone to dependency cycles, as it depends on our data structures.

If this makes sense to you, pls move you the helper func inside a respective module/domain package.

Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts

@renaynay
Copy link
Member Author

renaynay commented Jan 5, 2022

@adlerjohn closing this PR in favour of #317

@renaynay renaynay closed this Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:block Raw blocks and erasure coded blocks
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

service/block, service/header: Move ExtendedHeader creation from BlockService to HeaderService
3 participants