-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service/block: Remove block fetching capability from BlockService
#277
Conversation
Btw, there should be a changelog entry for this one. |
@adlerjohn, note that this PR is a part of a bigger goal and changes here might not make sense in isolation |
@Wondertan I gathered that much 😂. So long as the noted peculiarities are expected I have no issue with them temporarily existing. |
@@ -0,0 +1,38 @@ | |||
package utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why utils?
I like the approach of making things reusable but in a modular domain-specific way, not a monolithic way. And we are already going with the former.
The latter:
services/
header_service.go
share_service.go
The former:
header/
service.go
share/
service.go
Same with utils. Having one big folder for all the utils is monolithic and prone to dependency cycles, as it depends on our data structures.
If this makes sense to you, pls move you the helper func inside a respective module/domain package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conflicts
@adlerjohn closing this PR in favour of #317 |
This PR is the first step necessary to resolve #251 (it resolves the first TODO).