Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit message code injection #52

Closed
ghost opened this issue Jun 14, 2017 · 1 comment Β· Fixed by #54
Closed

commit message code injection #52

ghost opened this issue Jun 14, 2017 · 1 comment Β· Fixed by #54
Labels

Comments

@ghost
Copy link

ghost commented Jun 14, 2017

Hello @carloscuesta 😎!

Issue:

Step to reproduce

? Enter the commit title: Fixing \`yarn run build\` script

Or whatever bash command line you insert between `. Other example :

$ gitmoji -c
? Choose a gitmoji: βœ…  - Adding tests.
? Enter the commit title: `echo "foobarbaz"`
? Enter the commit message: 
? Issue / PR reference: 
? Signed commit: Yes
[dev 709eefb] :white_check_mark: foobarbaz

What is expected

A commit message with the selected emoji and text above

Actual Behavior

The ` are removed from the commit message and the command is executed with the output printed inside the commit message.

OS: Archlinux
gitmoji-cli -v: 1.5.5
Node version: v7.10.0

@carloscuesta
Copy link
Owner

Thanks for reporting the issue I'm working on a fix @KevinHivert

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant