Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backticks in commit messages #80

Closed
mecha opened this issue Nov 20, 2017 · 3 comments
Closed

Backticks in commit messages #80

mecha opened this issue Nov 20, 2017 · 3 comments

Comments

@mecha
Copy link

mecha commented Nov 20, 2017

Hello @carloscuesta!

We use backticks ("`") in our commit messages around things like class names, function names etc. However, using backticks in the commit title and description CLI prompts does not appear to be possible, or perhaps I fail to see how it is possible.

Error Message: "Enter a valid commit title"

OS: Ubuntu 16.04 under WSL
gitmoji-cli -v: 1.8.4
Node version: 9.2.0

Thanks in advance!

Edit:

After creating the issue, I found that this is being explicitly checked for in the title guard and message guard. Are there any plans for changing this?
Or rather ... is there anyway I can convince you to change this? 😄

@carloscuesta
Copy link
Owner

Hey @mecha!

This was introduced as of #52, I have no problem on removing it but taking in consideration the security

@CypherPoet
Copy link

I seem to be experiencing this same issue as of 5.0.0. Reading through the linked issues, it looks like this was intended to be resolved (?) -- but perhaps I'm misinterpreting that.

@CalinZBaenen
Copy link

I'm now having the same issue on Arch Linux.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants