Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checklist for a new study #248

Closed
16 tasks
jjgao opened this issue Jul 3, 2018 · 10 comments
Closed
16 tasks

checklist for a new study #248

jjgao opened this issue Jul 3, 2018 · 10 comments
Assignees

Comments

@jjgao
Copy link
Member

jjgao commented Jul 3, 2018

@ritikakundra do we have a checklist for a new study. Could you refine the list below?

  • Does study name and study ID follow our convention? e.g. Tumor_Type (Institue, Journal Year); brca_mskcc_2015. For mixed studies, let's not use mixed and decide case by case.
  • is study meta data complete? e.g. pmid, group of PUBLIC
  • were all samples profiled with WES/WGS? If not, is gene panel file curated?
  • with matched normal?
  • when pushing data out from msk-impact, germline mutations should be removed (unless they are used in the paper)
  • are oncotree codes of all samples curated; Cancer Type and Cancer Type Detailed needs to be added in addition to Oncotree Code
  • clinical sample and patient data with meta files
  • mutations data with meta files
  • MAF is based on hg19
  • MAF with 2 isoforms: uniprot and mskcc
  • CNA data with meta files
  • CNA segment data with meta files
  • Expression data including z-scores with meta files
  • Case-lists for all profiles.
  • Passes Validation
  • Manual checking (Niki or JJ): MSKCC or Triage Portal
@ritikakundra
Copy link
Collaborator

ritikakundra commented Jul 6, 2018

@jjgao I added meta-studies to all the data files and case lists. But I don't know if CNA, segment, and expression is a must for public studies, since most publications we see only have mutations data. The MAF is the minimum genomic data file required for a study to be created.

@jjgao
Copy link
Member Author

jjgao commented Jul 6, 2018

@ritikakundra if data does not exist, you can also check it off. The purpose of a checklist is to check one by one. And we can also evolve this list over time.

To utilize this checklist, one option would be creating a pull request per study with this checklist in the PR.

@jjgao
Copy link
Member Author

jjgao commented Jul 6, 2018

cc'ing @schultzn to see if he has anything to add.

@ritikakundra
Copy link
Collaborator

@jjgao ok. Added a few more things

@jjgao
Copy link
Member Author

jjgao commented Jul 6, 2018

Thanks, @ritikakundra. Let's start to use this checklist when pushing out new studies?

@ritikakundra
Copy link
Collaborator

@yichaoS @rmadupuri Our checklist for any dataset that goes public.

@jjgao
Copy link
Member Author

jjgao commented Jul 6, 2018

@ritikakundra @yichaoS @rnugraha let's also try to improve this checklist over time. For new studies, could you create a pull request per study and paste this checklist there? Thanks.

@schultzn
Copy link

schultzn commented Jul 8, 2018

looks good to me!

@rnugraha
Copy link
Member

rnugraha commented Jul 9, 2018

@sandertan you might also want to check this

@jjgao jjgao mentioned this issue Aug 13, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants