Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtest.py): Improve error handling and logging for operations #4093

Merged
merged 1 commit into from
Mar 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/coding_guidelines_check.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def run_clang_format_diff(root: Path, commits: str) -> bool:
found = False
for summary in [x for x in diff_content if x.startswith("diff --git")]:
# b/path/to/file -> path/to/file
with_invalid_format = re.split("\s+", summary)[-1][2:]
with_invalid_format = re.split(r"\s+", summary)[-1][2:]
if not is_excluded(with_invalid_format):
print(f"--- {with_invalid_format} failed on code style checking.")
found = True
Expand Down
2 changes: 1 addition & 1 deletion test-tools/addr2line/addr2line.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def get_line_info_from_function_addr_sourcemapping(
if not line:
continue

m = re.match("(.*):(\d+):(\d+)", line)
m = re.match(r"(.*):(\d+):(\d+)", line)
if m:
function_file, function_line, function_column = m.groups()
continue
Expand Down
6 changes: 4 additions & 2 deletions tests/wamr-test-suites/spec-test-script/all.py
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ def test_case(
CMD,
bufsize=1,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
stderr=subprocess.STDOUT,
universal_newlines=True,
) as p:
try:
Expand Down Expand Up @@ -285,7 +285,9 @@ def test_case(
except subprocess.TimeoutExpired:
print("failed with TimeoutExpired")
raise Exception(case_name)

except Exception as e:
print(f"An unexpected error occurred: {e}")
raise e

def test_suite(
target,
Expand Down
Loading
Loading