Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtest.py): Improve error handling and logging for operations #4093

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

lum1n0us
Copy link
Collaborator

No description provided.

@lum1n0us lum1n0us force-pushed the fix/ci_issue_aot branch 3 times, most recently from 1a9afc7 to 839d15d Compare March 16, 2025 23:16
…ng temporary files

- Replace sys.exit with exceptions for better error handling in test assertions
- Update exception handling in compile_wast_to_wasm to catch all exceptions
- Improve error messages and logging
- Use `--ignore-whitespace` option for git apply in spec_test function
- Use raw string notation for regex patterns.  *The "SyntaxWarning: invalid escape sequence" in Python The warning has been upgraded to SyntaxWarning since Python 3.12, and it is expected to become a SyntaxError in future versions.*
- Add early return for non-loadable AOT compilation to prevent unnecessary assertions
- Redirect stderr to stdout in test_case for unified output
- Update create_tmpfiles function to improve clarity and handling of temporary files
@lum1n0us lum1n0us marked this pull request as ready for review March 17, 2025 01:57
Copy link
Collaborator

@TianlongLiang TianlongLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lum1n0us lum1n0us merged commit 06ea960 into bytecodealliance:main Mar 20, 2025
386 checks passed
@lum1n0us lum1n0us deleted the fix/ci_issue_aot branch March 20, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] Random but frequent failures occur on the spec test for GC in x86-32 mode on Ubuntu 22.04.
3 participants