-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch grants update #291
batch grants update #291
Conversation
Our first release of Xion, a cosmsos-sdk v0.47.0 based blockchain featuring CosmWasm smart contracts and a custom mint module. ## What's Changed * Bump cosmossdk.io/math from 1.0.0-rc.0 to 1.0.0 by @dependabot in #4 * Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.2 to 1.0.0-beta.3 by @dependabot in #3 * Mint by @bigs in #7 * Mint Tests by @ash-burnt in #10 * Bump github.com/CosmWasm/wasmvm from 1.2.1 to 1.2.2 by @dependabot in #15 * Bump actions/checkout from 2 to 3 by @dependabot in #13 * Bump actions/cache from 2 to 3 by @dependabot in #12 * Bump github.com/cosmos/gogoproto from 1.4.6 to 1.4.7 by @dependabot in #6 * Fix libwasmvm dependency by @bigs in #17 **Full Changelog**: https://github.com/burnt-labs/xion/commits/v1.0.0
## Notes Proper store upgrade, ibc-hooks, packet forward middleware Includes the globalfee module, account abstraction, a number of dependency upgrades and audit adjustments ## What's Changed * remove race condition from sendtest by @ash-burnt in #94 * ibc hooks and packet forward middleware by @ash-burnt in #93 **Full Changelog**: v1.0.0...v2.0.0
## What's Changed * Feature: global fee ante handle sets gas for fee deduction by @edjroz in #97 * DAPP-573 - Fee Abstraction Module by @ash-burnt in #91 * add upgrade for fee abstraction by @ash-burnt in #101 adding fee abstraction **Full Changelog**: v2.0.0...v3.0.0
## 🛠️ Upgrades - Pfm migration - PR: #176 ## What's Changed * Open up cors on the xion testnet docker build by @justinbarry in #140 * remove dependabot by @ash-burnt in #143 * AA Signature by @edjroz in #131 * JWT Integration Test by @ash-burnt in #129 * Fix `xiond export` by @froch in #162 * Point upgrades of cosmos/wasm/ibc dependencies by @ash-burnt in #159 * Trigger GH workflows on tags by @froch in #169 * Fix Docker build by @froch in #170 * Fix wasmvm version and checksums by @froch in #171 * query endpoints for webauthn validation by @ash-burnt in #147 * JWK Module + JWT Verification by @ash-burnt in #158 * ACL by @ash-burnt in #164 * Pfm migration by @edjroz in #176 **Full Changelog**: v3.1.0...v3.1.1
## 🛠️ Upgrades - Docker Scout pass - PR: #178 **Full Changelog**: v3.1.1...v4.0.0
## 🛠️ Upgrades - JWK Util and re-upgrade for params - PR: #182 - Globalfee modifiers - PR: #183 ## 🔨 Fixes - drop to alpine 18 to avoid lib issues with wasmvm - PR: #181 - Fix Docker Scout invocation - PR: #184 ## What's Changed * drop to alpine 18 to avoid lib issues with wasmvm by @ash-burnt in #181 * JWK Util and re-upgrade for params by @ash-burnt in #182 * Patch/globalfee multipliers by @edjroz in #183 * Fix Docker Scout invocation by @froch in #184 **Full Changelog**: v4.0.0...v5.0.0
## 🛠️ Upgrades - Token Factory module - PR: #186 - wasmd fork - PR: #177 - Upgrade IBC to 7.4.0 - PR: #165 ## 🔨 Fixes - fixes for jwk utils and queries - PR: #185 - Fix Release GH Action build target - PR: #191 ## 🚧 Chores - pre-audit linting and cleanup - PR: #188 - Add IBC upgrade table-driven tests - PR: #190 **Full Changelog**: v5.0.0...v6.0.0
## 🧨 Audit Fixes - item 1: jwk commit reveal - PR: #202 - Item 2: Prove that key rotation works - PR: #192 - Item 3: Check for shared key types during validation - PR: #193 - Item 4: validate admin addr on genesis audiences - PR: #194 - Item 5: allow optional non-sender admin in cli - PR: #195 - Item 6: check new admin format during validate basic - PR: #196 - item 7: Add jwk delete msg to global fee - PR: #201 - Audit Item 8: register command, can add jwt - PR: #203 - Item 10: return new audience from state modification handlers - PR: #198 - Item 12: return the private claims from a successful jwt check - PR: #200 - Item 15: max page sizes in audience query to 100 - PR: #199 ## 🔨 Fixes - remove incorrect replace commands - PR: #212 ## 🛠️ Upgrades - query commands for webauthn - PR: #204 - Feat/auto passkey - PR: #207 - feegrants for authz and smart contracts - PR: #206 - v7 Upgrades - PR: #213 ## 🚧 Chores - Upgrade indirect dependencies - PR: #197 - Replace AWS access keys with OIDC assume-role - PR: #208
## 🛠️ Upgrades - Software Upgrade v8.0.0 - PR: #222 - Feat/treasury contract - PR: #211 - enable snapshot cli - PR: #218 - Update abtract-account to register amino structure in codec - PR: #221 - add in authz stargate query - PR: #209 - update globalfee params, to revoke grants - PR: #223 ## 🔨 Fixes - updated contracts for dlmalloc issue - PR: #216 - test fix: import correct types - PR: #219 ## 🚧 Chores - None !
## 🔨 Fixes - Fix wasmvm SIGABRT regression - PR: #227
## What's Changed * Chore/build release (#239) by @2xburnt in #240 * Revoking of allowances by @edjroz in #230 * Pull all jobs to the same level by @ash-burnt in #243 * Add devnet environment by @2xburnt in #241 * Fix typo in ./proto/xion/jwk/v1/query.proto by @2xburnt in #234 * Update readme by @2xburnt in #238 * Add workflow dispatch to primary workflows, eliminate second files by @2xburnt in #242 * Fix workflow tags by @2xburnt in #244 * Update Dockerfile for multiplatform builds by @2xburnt in #246 * Fix `make protocgen` script, needs relative path by @2xburnt in #250 * Chore/devnet by @2xburnt in #249 * Fix gosec errors by @2xburnt in #253 * Fix docker pull error by @2xburnt in #254 **Full Changelog**: v9.0.0...v9.0.1
## What's Changed * Upgrade to Cosmos SDK v50.9 with help from @01builders * refactor test to have bellow and equal gas transactions by @edjroz in #233 * try running with wasmd 51 by @ash-burnt in #235 * fix: add SetPreblocker that was preventing upgrades from working by @facundomedica in #251 * merge new workflows from main by @2xburnt in #255 ## New Contributors * @facundomedica made their first contribution in #251 **Full Changelog**: v9.0.1...v10.0.0
## Do not use!!! ## Use [v11.0.1](https://github.com/burnt-labs/xion/releases/tag/v11.0.1) instead This release contains a bug introduced by a forked version of cosmos-sdk that causes multiple consensus delays. ## What's Changed * feat: add in grpc query to wasmd by @Peartes in #256 * Add Simulate Test by @edjroz in #220 * upgrade cosmos sdk to v0.50.10 by @2xburnt in #260 **Full Changelog**: v10.0.0...v11.0.0
- Remove overridden SDK **Full Changelog**: v11.0.0...v11.0.1
## What's Changed * Updates to CI pipelines, use goreleaser to add darwin builds by @2xburnt in #263 * Remove overridden sdk by @ash-burnt in #262 * Enable wasm light clients by @ash-burnt in #258 **Full Changelog**: v11.0.1...v12.0.0
Remove IBCWasm upgrade **Full Changelog**: v12.0.0...v12.0.1
## 📦 Uncategorized - remove ibc wasm - PR: #265 - add heighliner push - PR: #266 - udpate release workflow to push heighliner images - PR: #268 - IBCWasm upgrade test and fix - PR: #269 ## What's Changed * remove ibc wasm by @ash-burnt in #265 * add heighliner push by @2xburnt in #266 * udpate release workflow to push heighliner images by @2xburnt in #268 * IBCWasm upgrade test and fix by @ash-burnt in #269 **Full Changelog**: v12.0.0...v13.0.0
## What's Changed * IBCWasm Store Added to Upgrade by @ash-burnt in #270 **Full Changelog**: v13.0.0...v13.0.1
## 📦 Uncategorized - Use direct client connection for simulation. - PR: #267 - feat: add in query platform fee into xion module - PR: #273 - Mint Module Bugfix - PR: #275 - up the wasm size limits - PR: #278 - Be able to set platform send minimums - PR: #271 ## What's Changed * Use direct client connection for simulation. by @edjroz in #267 * feat: add in query platform fee into xion module by @Peartes in #273 * Mint Module Bugfix by @ash-burnt in #275 * up the wasm size limits by @ash-burnt in #278 * Be able to set platform send minimums by @ash-burnt in #271 **Full Changelog**: v13.0.1...v14.0.0
🔍 Vulnerabilities of
|
digest | sha256:8296c887b3f5699e766bd2b3176c9df5d696c68138445e5d55a1bc32250a7105 |
vulnerabilities | |
platform | linux/amd64 |
size | 116 MB |
packages | 344 |
📦 Base Image alpine:3.20
also known as |
|
digest | sha256:a180ec8e5c7247c920c91508fa4ce86088946cc9e65f4aeb39091038bba88b0b |
vulnerabilities |
Description
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
Description
Description
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
Description
Description
Description
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
|
Footnotes
-
following Amulet's Severity Classification Framework ACMv1: https://github.com/interchainio/security/blob/e0227a1fb4059144aab4f6003eeee7f09912db3a/resources/CLASSIFICATION_MATRIX.md ↩ ↩2 ↩3
Sorry about the WIP. It's ready to be reviewed |
@Peartes Could you put together a quick demo video of this feature? |
func TestUpdateTreasuryConfigsWithLocalAndURL(t *testing.T) { | ||
flag.Parse() | ||
// require.NotNil(t, configFileUrl, "No config file is provided via the configUrl flag") | ||
configFileUrl = "https://raw.githubusercontent.com/burnt-labs/xion/refs/heads/feat/json-grants/integration_tests/testdata/unsigned_msgs/plain_config.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this disappear when the branch goes away?
# Note: This is dependent on #291 being merged in first # 🚀 Add `update-params` CLI Command & Integration Test for Contract State Updates ## **Summary** This PR introduces a new **CLI command** (`update-params`) that allows updating smart contract parameters on-chain. It also includes a **comprehensive integration test** to verify the correctness of the command. ## **Key Changes** ✅ **Added `update-params` CLI Command** - Enables users to update contract parameters (`display_url`, `redirect_url`, and `icon_url`) via the CLI. - Uses `MsgExecuteContract` to send an `updateParams` message to the specified contract. ✅ **Implemented Integration Test (`TestUpdateContractParams`)** - **Deploys & Instantiates** the contract with initial values. - **Executes `update-params` CLI command** to modify contract state. - **Queries & Validates** the contract to ensure changes were applied correctly. ## **How to Test** Run the integration test using: ```sh make test-integration-xion-update-treasury-params --------- Signed-off-by: TwiceBurnt <169301814+2xburnt@users.noreply.github.com> Co-authored-by: 2xburnt <169301814+2xburnt@users.noreply.github.com>
# Note: This is dependent on #291 being merged in first # 🚀 Add `update-params` CLI Command & Integration Test for Contract State Updates ## **Summary** This PR introduces a new **CLI command** (`update-params`) that allows updating smart contract parameters on-chain. It also includes a **comprehensive integration test** to verify the correctness of the command. ## **Key Changes** ✅ **Added `update-params` CLI Command** - Enables users to update contract parameters (`display_url`, `redirect_url`, and `icon_url`) via the CLI. - Uses `MsgExecuteContract` to send an `updateParams` message to the specified contract. ✅ **Implemented Integration Test (`TestUpdateContractParams`)** - **Deploys & Instantiates** the contract with initial values. - **Executes `update-params` CLI command** to modify contract state. - **Queries & Validates** the contract to ensure changes were applied correctly. ## **How to Test** Run the integration test using: ```sh make test-integration-xion-update-treasury-params --------- Signed-off-by: TwiceBurnt <169301814+2xburnt@users.noreply.github.com> Co-authored-by: 2xburnt <169301814+2xburnt@users.noreply.github.com>
Title: Add CLI Command to Update Treasury Configs & Fix Integration Test Gas Issue
Summary:
This PR introduces a new CLI command
update-configs
to batch update grant and fee configurations for the treasury contract. Additionally, it addresses an issue in the integration testTestUpdateTreasuryConfigsWithAALocalAndURL
where setting an insufficient gas fee caused node container failures without meaningful error logs.Changes Introduced:
New CLI Command:
update-configs
Integration Test Updates:
Implementation Details:
CLI Command:
update-configs
Usage:
Features:
--local
: Specifies that the config source is a local file instead of a URL.Integration Test:
TestUpdateTreasuryConfigsWithAALocalAndURL
Issue Fixed:
Key Fixes: