Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibc hooks and packet forward middleware #93

Merged
merged 10 commits into from
Aug 3, 2023
Merged

ibc hooks and packet forward middleware #93

merged 10 commits into from
Aug 3, 2023

Conversation

ash-burnt
Copy link
Contributor

No description provided.

@ash-burnt ash-burnt requested a review from edjroz July 31, 2023 12:29
@ash-burnt ash-burnt marked this pull request as ready for review July 31, 2023 12:29
@ash-burnt ash-burnt temporarily deployed to CI July 31, 2023 12:49 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI July 31, 2023 12:49 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI July 31, 2023 12:49 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI July 31, 2023 12:49 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI July 31, 2023 12:49 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 16:20 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 16:20 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 16:20 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 16:20 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 16:27 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 16:27 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 16:27 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 16:27 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 16:27 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 16:45 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 16:45 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 16:45 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 16:45 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 16:45 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 17:42 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 17:42 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 17:42 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 17:42 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 1, 2023 17:42 — with GitHub Actions Inactive
edjroz
edjroz reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@edjroz edjroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After vetting the upgrade it looks like this should be the next version of the protocol. That said a couple of suggestions:

  • Change Version on the Makefile to match the upgrade version.
  • Change the upgrade target commit on the integration_test/upgrade_test.go this should help us keep track of what version we lock in.

@ash-burnt ash-burnt temporarily deployed to CI August 3, 2023 13:21 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 3, 2023 13:21 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 3, 2023 13:21 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 3, 2023 13:21 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 3, 2023 13:21 — with GitHub Actions Inactive
@ash-burnt ash-burnt requested a review from edjroz August 3, 2023 13:23
@ash-burnt ash-burnt temporarily deployed to CI August 3, 2023 13:28 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 3, 2023 13:28 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 3, 2023 13:28 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 3, 2023 13:28 — with GitHub Actions Inactive
@ash-burnt ash-burnt temporarily deployed to CI August 3, 2023 13:28 — with GitHub Actions Inactive
edjroz
edjroz approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@edjroz edjroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🎊

@ash-burnt ash-burnt merged commit 455cfa5 into main Aug 3, 2023
@2xburnt 2xburnt deleted the feat/ibc-hooks branch July 22, 2024 02:13
2xburnt added a commit that referenced this pull request Dec 21, 2024
@2xburnt
squashed v2.0.0
5d93e6b 
git diff v2.0.0 - ''

## Notes
Proper store upgrade, ibc-hooks, packet forward middleware
Includes the globalfee module, account abstraction, a number of dependency upgrades and audit adjustments

## What's Changed
* remove race condition from sendtest by @ash-burnt in #94
* ibc hooks and packet forward middleware by @ash-burnt in #93

**Full Changelog**: v1.0.0...v2.0.0
2xburnt added a commit that referenced this pull request Dec 21, 2024
@2xburnt
squashed v2.0.0: https://github.com/burnt-labs/xion/compare/v2.0.0
ef053fb 
## Notes
Proper store upgrade, ibc-hooks, packet forward middleware
Includes the globalfee module, account abstraction, a number of dependency upgrades and audit adjustments

## What's Changed
* remove race condition from sendtest by @ash-burnt in #94
* ibc hooks and packet forward middleware by @ash-burnt in #93

**Full Changelog**: v1.0.0...v2.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edjroz edjroz edjroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ash-burnt @edjroz