Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the Any.is function #294

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Enhance the Any.is function #294

merged 1 commit into from
Nov 10, 2022

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Nov 9, 2022

This enhances the Any.is function to allow for passing a typeName as either a MessageType or a string representation of a typeName.

@smaye81 smaye81 requested a review from timostamm November 9, 2022 21:29
@smaye81 smaye81 merged commit 9d4255f into main Nov 10, 2022
@smaye81 smaye81 deleted the sayers/enhance_any_is branch November 10, 2022 13:47
smaye81 added a commit that referenced this pull request Nov 11, 2022
This enhances the `Any.is` function to allow for passing a `typeName` as
either a `MessageType` or a string representation of a typeName.
@smaye81 smaye81 mentioned this pull request Nov 23, 2022
smaye81 added a commit that referenced this pull request Nov 23, 2022
This release includes the following:

## Enhancements
* Add a toJSON method to messages by @smaye81 in #306
* Add an unpack function to `google.protobuf.Any` by @smaye81 in #303
* Make generated imports look more normal by @dimitropoulos in #298
⚠️ Note that as a result of this PR, import statements in your
generated code will contain diffs when generated with `v0.3.0` as the
import statements will have spaces added. For example:
   ```diff
   - import {FooMessage} from './foo_message_pb.js';
   + import { FooMessage } from './foo_message_pb.js';
   ```
* Add print function with tagged template literal by @yukukotani in #279
* Enhance the `Any.is` function by @smaye81 in #294
* Make wrappers more lenient by @timostamm in #291

## Bugfixes
* Fix map equality by @calebdoxsey in #305
* Make `tsNocheck` work correctly by @yukukotani in #275

## New Contributors
@calebdoxsey made their first contribution in #305
@yukukotani made their first contributions in #275 and #279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants