Make wrappers more lenient #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #283 by removing code path that errors. We can easily and reliably determine whether a field is already wrapped by checking if it is `instanceof Message`.
smaye81
approved these changes
Nov 7, 2022
timostamm
commented
Nov 7, 2022
Comment on lines
+21
to
+25
| describe("mixing message instances", () => { | ||
| const message = new TS_MessageFieldMessage(); | ||
| message.messageField = new JS_MessageFieldMessage_TestMessage({ | ||
| name: "foo", | ||
| }); |
There was a problem hiding this comment.
This covers the use case of #283 by using a message of the JavaScript generated code for a field of a message from the TypeScript generated code, proving that we no longer error.
Also added many more tests around wrappers.
Comment on lines
+82
to
84
| wrapField(value: number): DoubleValue { | ||
| return new DoubleValue({value}); | ||
| }, |
There was a problem hiding this comment.
This simplifies the generated code by making the internal function wrapField idempotent instead of this FieldWrapper. I don't like changing this, but it the generated code does look quite a bit nicer...
smaye81
pushed a commit
that referenced
this pull request
Nov 11, 2022
Merged
smaye81
added a commit
that referenced
this pull request
Nov 23, 2022
This release includes the following: ## Enhancements * Add a toJSON method to messages by @smaye81 in #306 * Add an unpack function to `google.protobuf.Any` by @smaye81 in #303 * Make generated imports look more normal by @dimitropoulos in #298⚠️ Note that as a result of this PR, import statements in your generated code will contain diffs when generated with `v0.3.0` as the import statements will have spaces added. For example: ```diff - import {FooMessage} from './foo_message_pb.js'; + import { FooMessage } from './foo_message_pb.js'; ``` * Add print function with tagged template literal by @yukukotani in #279 * Enhance the `Any.is` function by @smaye81 in #294 * Make wrappers more lenient by @timostamm in #291 ## Bugfixes * Fix map equality by @calebdoxsey in #305 * Make `tsNocheck` work correctly by @yukukotani in #275 ## New Contributors @calebdoxsey made their first contribution in #305 @yukukotani made their first contributions in #275 and #279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283 by removing code path that errors. We can easily and reliably determine whether a field is already wrapped by checking if it is
instanceof Message.