Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Update minimum Node version on README.md and package.json #9817

Merged
merged 1 commit into from
Jul 2, 2017
Merged

Update minimum Node version on README.md and package.json #9817

merged 1 commit into from
Jul 2, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jul 1, 2017

Fixes #9797

Auditors:

Test Plan:

  1. Update Node to >=7.9.0
  2. npm install

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fixes #9797

Auditors:

Test Plan:
1. Update Node to >=7.9.0
2. npm install
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes look great, npm install works great on macOS, Linux, and Windows (I wanted to check since the node-gyp version was bumped)

Thanks for catching this and updating 😄 👍

@bsclifton bsclifton merged commit 69ec8e8 into brave:master Jul 2, 2017
bsclifton added a commit that referenced this pull request Jul 2, 2017
Update minimum Node version on README.md and package.json
bsclifton added a commit that referenced this pull request Jul 2, 2017
Update minimum Node version on README.md and package.json
bbondy pushed a commit that referenced this pull request Jul 17, 2017
Update minimum Node version on README.md and package.json
@bbondy bbondy modified the milestones: 0.17.17 (Release Channel), 0.18.x (Release Channel) Jul 17, 2017
@luixxiul luixxiul deleted the update-readme branch August 2, 2017 09:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants