Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Update minimum Node version on README.md #9797

Closed
luixxiul opened this issue Jun 30, 2017 · 6 comments
Closed

Update minimum Node version on README.md #9797

luixxiul opened this issue Jun 30, 2017 · 6 comments

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: Update minimum Node version on README.md.

With v7.3.0 I got an unit test error, which is:

  1444 passing (17s)
  47 pending
  1 failing

  1) downloadsBar component very narrow downloads bar with items renders no downloads:

      AssertionError: 3 == 0
      + expected - actual

      -3
      +0
      
      at Context.<anonymous> (test/unit/app/renderer/components/download/downloadBarTest.js:118:14)

The error was fixed by updating Node to v7.9.0.

We could update it to 8 instead of it, though I am not sure if the browser is fully compatible with that newer version.

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS

  • Brave Version (revision SHA): master

  • Steps to reproduce:

    1. git push
  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:

@luixxiul luixxiul added this to the 0.18.x (Developer Channel) milestone Jun 30, 2017
@luixxiul
Copy link
Contributor Author

Let's decide the version number soon, since there might be a chance where other contributors also experience the bug.

@bsclifton
Copy link
Member

bsclifton commented Jun 30, 2017

I think it's safe to recommend 7.9.0 (or newer) 👍

We can now also remove this part:

2. node-gyp 3.3.1

 sudo npm install -g node-gyp@3.3.1

and update
Install the Node (v5+) dependencies:
to
Install the Node dependencies:

@luixxiul
Copy link
Contributor Author

luixxiul commented Jul 1, 2017

It is ok to remove node-gyp though there are several files where node-gyp seems to be called?

@luixxiul
Copy link
Contributor Author

luixxiul commented Jul 1, 2017

@bsclifton
Copy link
Member

@luixxiul correct, you can remove the global instance... because we already include it as a module in our package.json:

"node-gyp": "^3.2.1",

I don't think it was ever needed to be installed globally. I haven't had it installed in over a year

@luixxiul
Copy link
Contributor Author

luixxiul commented Jul 1, 2017

I see. I'm going to create a PR.

@bbondy bbondy modified the milestones: 0.17.17 (Release Channel), 0.18.x (Release Channel) Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants