This repository was archived by the owner on Dec 11, 2019. It is now read-only.
use cr62 download api #11466
Merged
use cr62 download api #11466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
referenced
this pull request
Oct 11, 2017
fix #11326 Auditors: @bridiver, @bbondy, @bsclifton Test Plan:
fix #11326 requires brave/muon#342
bridiver
force-pushed
the
issue-11326-2
branch
from
0b99c3a to
44d164e
Compare
bridiver
commented
Oct 12, 2017
| if (state === 'completed') { | ||
| let finalSavePath = item && item.getSavePath() | ||
| let pdfDataURI = 'data:application/pdf;base64,' + data.toString('base64') | ||
| tab.downloadURL(pdfDataURI, true, savePath, (downloadItem) => { |
There was a problem hiding this comment.
I can't verify this works at the moment because printToPDF is broken in cr62
bbondy
approved these changes
Oct 12, 2017
8 tasks
darkdh
suggested changes
Oct 12, 2017
app/pdf.js
Outdated
| let savePath = action.savePath | ||
| let openAfterwards = action.openAfterwards | ||
| const tabs = require('./browser/tabs') | ||
| const {fileUrl} = require('../../js/lib/appUrlUtil') |
There was a problem hiding this comment.
path should be ../js/lib/appUrlUtil
There was a problem hiding this comment.
pushed out a fix for that to this branch
NejcZdovc
modified the milestones:
0.20.x (Beta Channel),
0.19.x Hotfix 2 (Release channel)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11326
requires brave/muon#342
I believe this PR will have to be modified for master, but the end result should be the same. Any other changes (file naming, etc..) in master should be replaced as this change already handles automatic renaming of files
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests