Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

File downloads not working #11326

Closed
petemill opened this issue Oct 6, 2017 · 5 comments
Closed

File downloads not working #11326

petemill opened this issue Oct 6, 2017 · 5 comments
Assignees
@bridiver
Labels
bug cr62 feature/download priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 release-notes/exclude
Milestone
0.19.x Hotfix 2 (...

Comments

@petemill
Copy link
Member

petemill commented Oct 6, 2017 •
edited
Loading

Description

When saving a file, after confirming the macOS Save dialog, the download does not proceed, and OS-level browser functionality is disabled, such as the OS Brave menu -> Quit Brave

Steps to Reproduce

  • Choose a file to download (at atom.io)
  • Save dialog pops up
  • Press Save on dialog (Cancel also causes menus to grey out and become unavailable)

Actual result:

  • Dialog disappears, but nothing happens, browser is still in the state that the dialog is there, e.g. menu items are greyed out, like Brave > Quit Brave
  • Temporary download file which was created during dialog open is removed

Expected result:

  • File is downloaded, and download bar shows

Reproduces how often: 100%

Brave Version

Brave: 0.20.3
rev: 10ec013
Muon: 4.5.3
libchromiumcontent: 62.0.3202.38
V8: 6.2.414.23
Node.js: 7.9.0
Update Channel: developer
OS Platform: macOS
OS Release: 17.0.0
OS Architecture: x64

Reproducible on current live release:
No
@petemill petemill added this to the 0.19.x Release 2 (Beta Channel) milestone Oct 6, 2017
@ghost ghost added the priority/P4 Minor loss of function. Workaround usually present. label Oct 6, 2017
@LaurenWags
Copy link
Member

Reproduced by @aekeus on Linux, removed MacOS label.

@LaurenWags LaurenWags changed the title File downloads not working on macOS File downloads not working Oct 6, 2017
@bbondy bbondy added the cr62 label Oct 7, 2017
@darkdh darkdh self-assigned this Oct 10, 2017
@bridiver
Copy link
Collaborator

there are many different types of file download links, can you please provide a specific url?

@bridiver
Copy link
Collaborator

nvm, I was able to repro at brave.com download

@petemill
Copy link
Member Author

@bridiver report description also mentions atom.io

darkdh added a commit that referenced this issue Oct 11, 2017
@darkdh
Temporary fix for file download until @bridiver muon changes is ready
a268cab 
fix #11326

Auditors: @bridiver, @bbondy, @bsclifton

Test Plan:
@darkdh darkdh mentioned this issue Oct 11, 2017
Closed
8 tasks
bridiver added a commit to brave/muon that referenced this issue Oct 11, 2017
@bridiver
fix download handling for cr62
524ff84 
pre-req for brave/browser-laptop#11326
@bridiver bridiver mentioned this issue Oct 11, 2017
Merged
bridiver added a commit that referenced this issue Oct 11, 2017
@bridiver
use cr62 download api
0b99c3a 
fix #11326
requires brave/muon#342
@bridiver bridiver mentioned this issue Oct 11, 2017
Merged
8 tasks
bridiver added a commit that referenced this issue Oct 12, 2017
@bridiver
use cr62 download api
44d164e 
fix #11326
requires brave/muon#342
@bridiver bridiver assigned bridiver and unassigned darkdh Oct 12, 2017
bbondy pushed a commit that referenced this issue Oct 13, 2017
@bridiver @bbondy
use cr62 download api
ff0e16a 
fix #11326
requires brave/muon#342
bbondy pushed a commit that referenced this issue Oct 13, 2017
@bridiver @bbondy
use cr62 download api
005b642 
fix #11326
requires brave/muon#342
bbondy pushed a commit that referenced this issue Oct 13, 2017
@bridiver @bbondy
use cr62 download api
6169150 
fix #11326
requires brave/muon#342
bbondy pushed a commit that referenced this issue Oct 13, 2017
@bridiver @bbondy
use cr62 download api
3644528 
fix #11326
requires brave/muon#342
@bbondy
Copy link
Member

bbondy commented Oct 13, 2017 •
edited
Loading

master: 3644528
0.21.x: 6169150
0.20.x: 976f1cb
0.19.x: 8be21a0

bbondy pushed a commit that referenced this issue Oct 18, 2017
@bridiver @bbondy
use cr62 download api
8be21a0 
fix #11326
requires brave/muon#342
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@bridiver @syuan100
use cr62 download api
e2bc47b 
fix brave#11326
requires brave/muon#342
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bridiver bridiver

Labels
bug cr62 feature/download priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 release-notes/exclude
Projects
None yet
Milestone
0.19.x Hotfix 2 (Release channel)
Development

Successfully merging a pull request may close this issue.

Temporary fix for file download brave/browser-laptop
8 participants
@bridiver @petemill @bbondy @kjozwiak @luixxiul @NejcZdovc @darkdh @LaurenWags