Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Polish bravery panel #10489

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Polish bravery panel #10489

merged 1 commit into from
Sep 5, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Aug 15, 2017

Closes #5726
Follow-up to #10181

  • Remove fixed width; now that we have the compact bravery panel, we would not have to take the possibility into consideration that the panel would cover the UI.
  • Increase padding-right from 1.5em to 2em on the dropdown to add 1em space between the option and the down arrow (See Block 3rd Party Fingerprinting option below).
  • Decrease the margin-bottom of the dropdown and Increase margin between switches

From:

screenshot 2017-08-15 16 29 57

To:

screenshot 2017-08-15 16 30 47

Here is an extreme example (which would not happen in reality, unless the font rendering is quite poor + screen resolution is very low).

screenshot 2017-08-15 16 43 10

That panel can be scrolled horizontally.

Auditors:

Test Plan:

  1. Change lang setting
  2. Restart the browser
  3. Open Bravery panel on an external site
  4. Make sure the strings are not wrapped

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@luixxiul luixxiul self-assigned this Aug 15, 2017
@luixxiul luixxiul added polish Nice to have — usually related to front-end/visual tasks. feature/shields l10n labels Aug 15, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 15, 2017
Closes #5726
Follow-up to #10181

- Remove fixed width
- Increase padding-right from 1.5em to 2em on the dropdown
- Increase margin between switches

Auditors:

Test Plan:
1. Change lang setting
2. Restart the browser
3. Open Bravery panel on an external site
4. Make sure the strings are not wrapped
@@ -993,6 +994,7 @@ const styles = StyleSheet.create({
braveryPanel__body__advanced__control: {
display: 'grid',
gridColumnGap: '1rem',
gridTemplateColumns: 'max-content max-content',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents the strings inside the dropdowns and the labels from wrapping, without forcing the same width for each column.

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit b848630 into brave:master Sep 5, 2017
@cezaraugusto cezaraugusto deleted the polish-braveryPanel branch September 5, 2017 00:01
@bbondy bbondy removed this from the 0.21.x (Developer Channel) milestone Oct 25, 2017
@luixxiul luixxiul added this to the 0.20.x (Beta Channel) milestone Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/shields l10n polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow-up to #5724: the bravery panel should be much wider
3 participants