Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Commit b848630

Browse files
authored
Merge pull request #10489 from luixxiul/polish-braveryPanel
Polish bravery panel
2 parents ed30f17 + 2b96466 commit b848630

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

app/renderer/components/common/dropdown.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ const styles = StyleSheet.create({
5555
height: '2rem',
5656
outline: 'none',
5757
// right padding is larger, to account for the down arrow SVG
58-
padding: `${selectPadding} 1.5em ${selectPadding} ${selectPadding}`,
58+
padding: `${selectPadding} 2em ${selectPadding} ${selectPadding}`,
5959
'-webkit-appearance': 'none',
6060
width: 'auto'
6161
},

app/renderer/components/main/braveryPanel.js

+9-3
Original file line numberDiff line numberDiff line change
@@ -528,6 +528,7 @@ class BraveryPanel extends React.Component {
528528
<SwitchControl className={css(
529529
!this.props.isCompactBraveryPanel && gridStyles.row6col1,
530530
this.props.isCompactBraveryPanel && gridStyles.row8col1,
531+
!this.props.isCompactBraveryPanel && styles.braveryPanel__body__advanced__control__switchControl_noScript,
531532
this.props.isCompactBraveryPanel && styles.braveryPanel_compact__body__advanced__control__switchControl
532533
)}
533534
onClick={this.onToggleNoScript}
@@ -727,13 +728,13 @@ const buttonSize = '13px'
727728
const styles = StyleSheet.create({
728729
braveryPanel: {
729730
padding: 0,
730-
width: '500px',
731731
right: '20px',
732732
userSelect: 'none',
733733
cursor: 'default',
734734
color: globalStyles.braveryPanel.color,
735735
overflowY: 'auto',
736-
maxHeight: `calc(100% - ${globalStyles.spacing.dialogTopOffset})`
736+
maxHeight: `calc(100% - ${globalStyles.spacing.dialogTopOffset})`,
737+
maxWidth: 'calc(100% - 40px)'
737738
},
738739
braveryPanel_compact: {
739740
width: 'auto',
@@ -993,6 +994,7 @@ const styles = StyleSheet.create({
993994
braveryPanel__body__advanced__control: {
994995
display: 'grid',
995996
gridColumnGap: '1rem',
997+
gridTemplateColumns: 'max-content max-content',
996998
margin: '15px 10px'
997999
},
9981000
braveryPanel__body__advanced__control__forms__title: {
@@ -1009,6 +1011,9 @@ const styles = StyleSheet.create({
10091011
alignItems: 'center',
10101012
justifyContent: 'space-between'
10111013
},
1014+
braveryPanel__body__advanced__control__switchControl_noScript: {
1015+
marginTop: '2.5px'
1016+
},
10121017
braveryPanel__body__advanced__control__switchControl__infoButton: {
10131018
display: 'inline',
10141019
cursor: 'pointer',
@@ -1018,12 +1023,13 @@ const styles = StyleSheet.create({
10181023

10191024
// controlWrapper - Normal Panel
10201025
braveryPanel__body__advanced__control__forms__dropdown: {
1021-
marginBottom: '25px'
1026+
marginBottom: '1rem'
10221027
},
10231028

10241029
// controlWrapper - Compact Panel
10251030
braveryPanel_compact__body__advanced__control: {
10261031
gridColumnGap: 0,
1032+
gridTemplateColumns: 'initial',
10271033
margin: 0,
10281034

10291035
// Align the advanced control wrapper with the counters

0 commit comments

Comments
 (0)