Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

flash placeholder regression #2489

Closed
diracdeltas opened this issue Jul 15, 2016 · 7 comments
Closed

flash placeholder regression #2489

diracdeltas opened this issue Jul 15, 2016 · 7 comments
Labels
plugin/flash regression
Milestone
0.11.1dev

Comments

@diracdeltas
Copy link
Member

#2480 (comment)
@diracdeltas diracdeltas added this to the 0.11.1dev milestone Jul 15, 2016
@diracdeltas
Copy link
Member Author

diracdeltas commented Jul 15, 2016 •
edited
Loading

@bbondy it appears that chrome.ipc is undefined when the about-flash.html is in an iframe instead of top-level

@bbondy
Copy link
Member

bbondy commented Jul 15, 2016

cc @bridiver can you fix this at the electron level?
Otherwise I'll have to revert the flash part of: 6d27a69

@bridiver
Copy link
Collaborator

do you have an example site? It should be defined if it's still an extension url

@diracdeltas
Copy link
Member Author

@bridiver http://www.y8.com/games/superfighters

@bridiver
Copy link
Collaborator

we should add a test for this in browser

@diracdeltas
Copy link
Member Author

thanks, will do

@diracdeltas diracdeltas mentioned this issue Jul 15, 2016
Closed
@diracdeltas
Copy link
Member Author

i'm still seeing this with the latest rc / latest electron release so reopening. test page http://www.y8.com/games/superfighters

@diracdeltas diracdeltas reopened this Jul 15, 2016
@luixxiul luixxiul mentioned this issue Jul 16, 2016
Closed
82 tasks
bbondy pushed a commit to brave/muon that referenced this issue Jul 18, 2016
@bridiver @bbondy
allow chrome.ipc in unlblessed extension pages
b5347d1 
fixes brave/browser-laptop#2489
luixxiul referenced this issue Jul 19, 2016
@bridiver
insert flash placeholders on dom load
ad8fb6d 
auditors: @bbondy, @diracdeltas
bridiver added a commit to brave/muon that referenced this issue Jul 27, 2016
@bridiver
allow chrome.ipc in unlblessed extension pages
40c074e 
fixes brave/browser-laptop#2489
bridiver added a commit to brave/muon that referenced this issue Aug 15, 2016
@bridiver
allow chrome.ipc in unlblessed extension pages
9b21c8a 
fixes brave/browser-laptop#2489
bridiver added a commit to brave/muon that referenced this issue Sep 17, 2016
@bridiver
allow chrome.ipc in unlblessed extension pages
c76f8d0 
fixes brave/browser-laptop#2489
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
plugin/flash regression
Projects
None yet
Milestone
0.11.1dev
Development

No branches or pull requests
4 participants
@bridiver @diracdeltas @bbondy @luixxiul