extension pages can't run in sandboxed iframes

bridiver · bridiver · commit 6eb540543cef · 2016-07-15T17:03:16.000-07:00
fixes #2489 auditors: @bbondy @diracdeltas
diff --git a/app/extensions.js b/app/extensions.js
@@ -76,16 +76,6 @@ let generateBraveManifest = () => {
         exclude_globs: [
           getAppUrl('about-blank.html')
         ]
-      },
-      {
-        run_at: 'document_start',
-        all_frames: true,
-        js: [
-          'content/scripts/brave-about-flash.js'
-        ],
-        matches: [
-          '<all_urls>'
-        ]
       }
     ],
     permissions: [
diff --git a/app/extensions/brave/content/scripts/brave-about-flash.js b/app/extensions/brave/content/scripts/brave-about-flash.js
diff --git a/app/extensions/brave/content/scripts/flashListener.js b/app/extensions/brave/content/scripts/flashListener.js
@@ -135,7 +135,6 @@ function insertFlashPlaceholders (elem) {
         return
       }
       let iframe = document.createElement('iframe')
-      iframe.setAttribute('sandbox', 'allow-scripts')
       let hash = window.location.origin
       if (chrome.contentSettings.flashEnabled == 'allow') {
         hash = hash + '#flashEnabled'

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,6 @@ function insertFlashPlaceholders (elem) {`
`135`	`135`	`return`
`136`	`136`	`}`
`137`	`137`	`let iframe = document.createElement('iframe')`
`138`		`- iframe.setAttribute('sandbox', 'allow-scripts')`
`139`	`138`	`let hash = window.location.origin`
`140`	`139`	`if (chrome.contentSettings.flashEnabled == 'allow') {`
`141`	`140`	`hash = hash + '#flashEnabled'`