Read lists from adblock-resources #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of brave/adblock-resources#4 we are moving to host filter lists in the adblock-resources repository, instead of in adblock-rust.
This change updates the DAT builder to pull lists from
filter_lists/default.jsonandfilter_lists/regional.jsonin the master branch of that repository.adblock-resources has a verification script to ensure that these files always contain valid content in any PRs merged against master.
In addition, this change produces a new file called
regional_catalog.jsonin thebuild/ad-block-updater/defaultfolder, which is essentiallyfilter_lists/regional.jsonfrom the adblock-resources repo. When shipped alongside the default DAT,brave-corewill be able to always show the most recently available selection of regional filter lists.