Move filter lists to be hosted in this repo #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a number of reasons, it would be super useful to host filter lists independently from
adblock-rust.I've duplicated the default and regional list descriptors as pure JSON and exported them from here. It should be possible to include these lists either by installing
adblock-resourcesas a dependency and using thedefaultListsandregionalListsexports (commit-locked), or by requesting directly from the rawfilter_lists/default.jsonandfilter_lists/regional.jsonfiles hosted in this repository.I've also expanded the
verify.jstestsuite to ensure that any updates to the filter lists are parsed correctly as JSON, and have all the expected fields with correct types. This is roughly on-par with the compile-time checks inadblock-rust; we could potentially expand the test suite further to enforce constraints on the values themselves - URLs parse correctly, UUIDs are actually unique, language codes are valid, etc.