Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom gesture detector #197

Merged
merged 9 commits into from
Nov 5, 2019
Merged

Custom gesture detector #197

merged 9 commits into from
Nov 5, 2019

Conversation

renancaraujo
Copy link
Member

@renancaraujo renancaraujo commented Nov 5, 2019

As discussed on @criswonder's #185, The proper way to deal with nested gesture detectors is implementing our own Gesture recognizer. In this PR:

@ghost
Copy link

ghost commented Nov 5, 2019

DeepCode Report (#e83273)

DeepCode analyzed this pull request.
There are no new issues.

@renancaraujo renancaraujo merged commit 1af0ef2 into master Nov 5, 2019
@renancaraujo renancaraujo deleted the custom-gesture-detector branch November 19, 2019 22:24
@criswonder
Copy link

criswonder commented Nov 20, 2019

Bro, nice job!
I tried the master branch's code, but it not work as expected! It's hard to change page when zoomed in. like this gif shows pls have a look

out1

@renancaraujo
Copy link
Member Author

@criswonder Yeah... That looks awful, on iOS and android devices that I've tested, I had not much trouble with this impl, but for sure we still have to look into some cases. Can you open an issue telling Flutter version, device model and android version?

@ghost ghost mentioned this pull request Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants