Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the picture directly zoomable when page is changed #133

Closed
msw333 opened this issue Apr 25, 2019 · 2 comments
Closed

Making the picture directly zoomable when page is changed #133

msw333 opened this issue Apr 25, 2019 · 2 comments
Labels
enhancement New feature or request Gallery

Comments

@msw333
Copy link

msw333 commented Apr 25, 2019

Comparing PhotoViewGallery.builder to native functionality, like e.g. within iOS, I find that the overall experience is different:

  1. Since scrolling between pages blocks zooming, I suggest, that the speed of transition speeds up (especially at the end). Any easy solution to do that? Otherwise, many users try zooming (which is blocked, even though the page appears to be already snapped in).

  2. Is there a way to block changing pages when two fingers are on the picture, so that zooming is the primary gesture?

  3. iOS allows you to change pages, even tough you are zoomed in (with a nice bouncing effect).

Thanks a lot - it's a great package.

@msw333 msw333 changed the title Speed up transition to not 'block' zooming that long on PhotoViewGallery Speed up transition to not 'block' zooming and block changing pages when two fingers are used Apr 25, 2019
@msw333 msw333 changed the title Speed up transition to not 'block' zooming and block changing pages when two fingers are used Making the picture directly zoomable when page is changed Apr 25, 2019
@renancaraujo renancaraujo added Gallery enhancement New feature or request labels Apr 27, 2019
@renancaraujo
Copy link
Member

We had lots of pf changes on the Gallery recently (#197). I believe your point 2 is now resolved.
Regarding blocking page change when zooming in, that was changed on #197 as well.

But we still have the problem regarding page change speed and I think the page change effect could be better. We can improve that in the future.

@renancaraujo
Copy link
Member

Since we got no answer for a while, I am automatically closing this issue for the sake of organization.
If there is any news on that, feel free to retake the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Gallery
Projects
None yet
Development

No branches or pull requests

2 participants