Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing Screen on video calls like google meet etc... #121

Closed
harryfornasier opened this issue Dec 9, 2022 · 14 comments
Closed

Sharing Screen on video calls like google meet etc... #121

harryfornasier opened this issue Dec 9, 2022 · 14 comments

Comments

@harryfornasier
Copy link

On chromium-legacy trying to share your screen on a Google meet call will result in it saying 'your browser can't share your screen'. The only alternative i've found is using firefox 78 which will let you screen share but screen sharing with audio doesn't work. Could this be a possible feature that can be added into chromium-legacy - Screen sharing and audio sharing on a call?

If it's impossible and is a limitation of using an Older OS then this can be closed.
@Wowfunhappy
Copy link

This used to work, so it should be fixable.

Would you be willing to go through and try to find the first build where it broke? Start with a very old Canary build--if it works, try a Canary build halfway between that version and the latest, and so on.

@Wowfunhappy
Copy link

Wowfunhappy commented Dec 9, 2022 •
edited
Loading

Odd, the following website works for me on Chromium Legacy 108.0.5359.94.2 on OS X 10.9.5 Mavericks.

https://www.webrtc-experiment.com/Pluginfree-Screen-Sharing/

@harryfornasier
Copy link
Author

I just had a look through a few and I got one to work: Version 882059. But I couldn't get audio sharing to work on it, did that part ever work?

Hmm that link works for me too. I wonder if the functionality is all there but google meet is somehow blocking it, thinking we're using an unsupported browser.

@Wowfunhappy
Copy link

I just had a look through a few and I got one to work: Version 882059. But I couldn't get audio sharing to work on it, did that part ever work?

Audio sharing as in talking into a microphone, or sharing system audio? I never tried the latter, but the former definitely worked at one point (I can't remember when I last used Google Meet, it was more than a year ago).

I wonder if the functionality is all there but google meet is somehow blocking it, thinking we're using an unsupported browser.

Maybe except then it's weird than an old version works. So if you have a chance it would be great to keep going through the bisect, we want to find the first version that broke it.

@harryfornasier
Copy link
Author

Ah I should have been more specific the audio sharing like microphone works no problem for me but sharing system audio has never worked - but that one doesn't work on firefox either so maybe it's an OS thing and not a browser one.

Okay cool, i'll keep looking and see what I can find

@harryfornasier
Copy link
Author

I did a bit more reading on it and it seems like Google Meet doesn't allow you to share system audio from any device. It only allows you to share audio from another chrome tab - I must have been remembering zoom or another call tool.

@harryfornasier
Copy link
Author

Took me a while but the last version for screen sharing to work is 945528 and it breaks in 945626

@pjpreilly
Copy link

Took me a while but the last version for screen sharing to work is 945528 and it breaks in 945626

Wow... a year old regression....

@Wowfunhappy
Copy link

I took a look through the commits between those tags and I don't see anything mentioning Mac or Screensharing or anything else obvious. :( I wish I knew what exactly is causing Google Meet to disable Screen Sharing, since we know the feature itself works on other sites...

blueboxd added a commit that referenced this issue Dec 11, 2022
@blueboxd
use the generic DesktopCaptureDevice on 10.7 to fix #121
4e9a096
@blueboxd
Copy link
Owner

@harryfornasier
Thank you for the investigation!
Fixed, please try with 108.0.5359.98.2.
(canary will also be fixed in the next build)

@Wowfunhappy
Thanks!
ungoogled-software/ungoogled-chromium#601
As mentioned above, we need enable_hangout_services_extension = true to use screen sharing with Google Meet...
But commit of the root cause is still unknown.

@jonholdsworth
Copy link

Very sorry, I'm using 108.0.5359.99-1.1 on Ubuntu 20.04 and the problem still occurs.

@Wowfunhappy
Copy link

Wowfunhappy commented Dec 13, 2022 •
edited
Loading

@jonholdsworth

I think you may have commented on the wrong project. This repository is for Chromium on legacy versions of Mac OS X.

@jonholdsworth
Copy link

jonholdsworth commented Dec 13, 2022 •
edited
Loading

My mistake. I was desperately scrabbling around trying to find others who had hit the same issue 😆

@felixding
Copy link

Wow! Awesome and big thank you! This is one of the two blockers for me to use Mavericks as my main OS (the other one is #75 by the way).

blueboxd added a commit that referenced this issue Jan 25, 2023
@blueboxd
use the generic DesktopCaptureDevice on 10.7 to fix #121
60e49c9
blueboxd pushed a commit that referenced this issue Feb 8, 2023
[iOS] Fix Incognito Search action
d0d66fb 
The action was wrongly created, leading to opening the search in
non-incognito.

(cherry picked from commit db47fbe)

Fixed: 1402647
Change-Id: I275f8ddcfb01e9d2da95aa12a0bac79d8df25b88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4120256
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Ewann Pellé <ewannpv@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1085949}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4136790
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/5481@{#121}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd added a commit that referenced this issue Feb 8, 2023
@blueboxd
use the generic DesktopCaptureDevice on 10.7 to fix #121
1ffd98c
blueboxd pushed a commit that referenced this issue Mar 7, 2023
[M111] Add openWebFeed command implementation.
bdcd09d 
Direct copy of https://chromium-review.googlesource.com/c/chromium/src/+/4028845

(cherry picked from commit 104b927)

Bug: 1380541
Change-Id: I8bb66b696256c58b080be32c1a18fcd28e444f59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4205190
Commit-Queue: Sophey Dong <sophey@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1098898}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4220051
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/branch-heads/5563@{#121}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
blueboxd pushed a commit that referenced this issue Apr 14, 2023
Incrementing VERSION to 112.0.5615.12
7509fc7 
Change-Id: Iad978d93ce8cb1828ccdb6946ac5032a54a8bd88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4301612
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5615@{#121}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd pushed a commit that referenced this issue May 9, 2023
[Merge M113] Add available memory histograms
2aeddcf 
This should help inform the choice of the heuristic memory saver
thresholds

(cherry picked from commit 1359b9c)

Bug: 1420344
Change-Id: Ic178c327c625e90558aab6db27a8e5639447d281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4361971
Reviewed-by: Joe Mason <joenotcharles@google.com>
Commit-Queue: Anthony Vallée-Dubois <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1122551}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4377527
Commit-Queue: Joe Mason <joenotcharles@google.com>
Auto-Submit: Anthony Vallée-Dubois <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/5672@{#121}
Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd pushed a commit that referenced this issue May 27, 2023
@sisidovski
[M114] [BestEffortServiceWorker] Enable the feature via hash based al…
a5db0fd 
…lowlist

This CL adds the allowlist support to RaceNetworkRequest. If the sha256
hash in ServiceWorkerVersion matches the list, the feature is enabled.
This mechanism will be used upcoming a/b experiment.

`FetchHandlerBypassedHashStrings` in
service_worker_controllee_request_handler.cc is moved to
`service_worker_loader_helpers` to avoid the code duplication between
ServiceWorkerControlleeRequestHandler and
ServiceWorkerMainResourceLoader.

(cherry picked from commit aaec3d9)

Bug: 1420517
Change-Id: I6aecfda4d8740aad4c0b534ba272b2c2fad58840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4479069
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1136229}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4495898
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/branch-heads/5735@{#121}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
blueboxd pushed a commit that referenced this issue Sep 10, 2023
[ ChromeRefresh2023 ] Fix caption button infinite layout loop.
e367578 
In touch UI on Windows, the frame height depends on the caption buttons'
preferred height.

In ChromeRefresh2023, the caption buttons vertically fill the frame. This was originally done by matching the preferred height of the caption
buttons to the frame's height, causing an infinite loop in touch ui.

Now, the preferred height of the caption buttons is calculated
independently of the frame height, breaking the dependency loop.

(cherry picked from commit dbd75a4)

Bug: 1469139
Change-Id: I778b3379923efc08ccab72ac5170463cc85bf5b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4771898
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/main@{#1182363}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4777997
Commit-Queue: David Pennington <dpenning@chromium.org>
Reviewed-by: David Pennington <dpenning@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/branch-heads/5938@{#121}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
blueboxd pushed a commit that referenced this issue Nov 6, 2023
Roll Chrome Linux PGO Profile
d3e7493 
Roll Chrome Linux PGO profile from chrome-linux-6045-1696570439-96a47e5de72e661203c1e9f6c8c329d5998e66e1.profdata to chrome-linux-6045-1696590050-dc8d7455649dd5b9f28845b733eabb5fabc42096.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m119.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ideacd2db9453b9fcc62ce446476b02ed832b0419
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4916639
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6045@{#121}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@felixding @Wowfunhappy @pjpreilly @harryfornasier @blueboxd @jonholdsworth