Skip to content
This repository was archived by the owner on Dec 8, 2022. It is now read-only.

Expose config #431

Merged
merged 11 commits into from
Jul 17, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/karma/shared.karma.conf.js
Original file line number Diff line number Diff line change
@@ -71,6 +71,7 @@ function getConfig(config) {
}
],
preprocessors: preprocessors,
skyPagesConfig: skyPagesConfig,
webpack: testWebpackConfig.getWebpackConfig(skyPagesConfig, argv),
coverageReporter: {
dir: path.join(process.cwd(), 'coverage'),
6 changes: 6 additions & 0 deletions config/protractor/protractor.conf.js
Original file line number Diff line number Diff line change
@@ -2,10 +2,16 @@
'use strict';

const path = require('path');
const minimist = require('minimist');
const SpecReporter = require('jasmine-spec-reporter').SpecReporter;
const logger = require('@blackbaud/skyux-logger');

// See minimist documentation regarding `argv._` https://github.com/substack/minimist

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :-)

const argv = minimist(process.argv.slice(2));
const skyPagesConfig = require('../sky-pages/sky-pages.config').getSkyPagesConfig(argv._[0]);

exports.config = {
skyPagesConfig: skyPagesConfig,
allScriptsTimeout: 11000,
specs: [
path.join(
9 changes: 9 additions & 0 deletions runtime/config.ts
Original file line number Diff line number Diff line change
@@ -19,6 +19,14 @@ export class SkyuxPactConfig {
public pactProxyServer?: string;
}

export interface SkyuxConfigUnitTestSettings {
browserSet?: 'speedy' | 'quirky' | 'paranoid';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like "speedy" and "quirky" :)

Instead of "paranoid", what do you think about "comprehensive" or "exhaustive", to put a more positive spin on it? (If Paul has already approved "paranoid", disregard.)

}

export interface SkyuxConfigTestSettings {
unit?: SkyuxConfigUnitTestSettings;
}

export interface RuntimeConfig {
app: RuntimeConfigApp;
command?: string; // Dynamically added in "higher up" webpacks
@@ -74,6 +82,7 @@ export interface SkyuxConfig {
public?: any[],
referenced?: any[]
};
testSettings?: SkyuxConfigTestSettings;
omnibar?: any;
useHashRouting?: boolean;
skyuxModules?: string[];
21 changes: 21 additions & 0 deletions skyuxconfig-schema.json
Original file line number Diff line number Diff line change
@@ -222,6 +222,27 @@
"skyuxModules": {
"description": "The individual SKY UX modules that should be imported into the application. Use this property for performance optimization when your application only uses a small subset of SKY UX components.",
"type": "array"
},
"testSettings": {
"description": "Container for controlling test settings.",
"type": "object",
"properties": {
"unit": {
"description": "Test settings specific to the skyux test command.",
"type": "object",
"properties": {
"browserSet": {
"description": "The named set of browsers to run against.",
"type": "string",
"enum": [
"speedy",
"quirky",
"paranoid"
]
}
}
}
}
}
}
}