Expose config #431
Expose config #431
Conversation
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 99.31% 99.31% +<.01%
==========================================
Files 73 73
Lines 1901 1904 +3
Branches 297 297
==========================================
+ Hits 1888 1891 +3
Misses 13 13
Continue to review full report at Codecov.
|
| const SpecReporter = require('jasmine-spec-reporter').SpecReporter; | ||
| const logger = require('@blackbaud/skyux-logger'); | ||
|
|
||
| // See minimist documentation regarding `argv._` https://github.com/substack/minimist |
Blackbaud-BobbyEarl
requested review from
Blackbaud-PaulCrowder and
Blackbaud-SteveBrush
| @@ -19,6 +19,14 @@ export class SkyuxPactConfig { | |||
| public pactProxyServer?: string; | |||
| } | |||
|
|
|||
| export interface SkyuxConfigUnitTestSettings { | |||
| browserSet?: 'speedy' | 'quirky' | 'paranoid'; | |||
There was a problem hiding this comment.
I like "speedy" and "quirky" :)
Instead of "paranoid", what do you think about "comprehensive" or "exhaustive", to put a more positive spin on it? (If Paul has already approved "paranoid", disregard.)
skyuxconfig-schema.json
Outdated
| @@ -2,6 +2,31 @@ | |||
| "$schema": "http://json-schema.org/draft-04/schema#", | |||
| "title": "JSON schema for SKY UX CLI skyuxconfig.json", | |||
| "definitions": { | |||
| "browserProperties": { | |||
There was a problem hiding this comment.
Are the browserProperties still being used somewhere?
There was a problem hiding this comment.
Nope. Good catch. Also realized I left the property as browsers instead of browserSet, so I've updated that too.
* Exposing the skyPagesConfig to karma and protractor configs. * Cleanup * Allowing device property * Allow all properties * Fixing type * Allowing supported property. * Using browserSet instead of browsers + supported. * Removed enums. * Update schema properties.
With blackbaud/skyux-builder-config#15, the default browser will revert back to Chrome. These changes introduce a way for SPAs to opt-in to custom browsers on Browserstack.