Skip to content
This repository was archived by the owner on Dec 8, 2022. It is now read-only.

Update help version #293

Merged
merged 6 commits into from
Oct 11, 2017
Merged

Update help version #293

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f5b0e01
updated builders dependency on the skyux-lib-help to suppor automatic…
Blackbaud-BrandonJones Oct 6, 2017
7472929
removed ~ from dependency
Blackbaud-BrandonJones Oct 6, 2017
1cc7d33
added a style over ride for the widget inside the builder's app compo…
Blackbaud-BrandonJones Oct 6, 2017
6a97ad2
going deep
Blackbaud-BrandonJones Oct 6, 2017
6eabd0c
update to 1.1.0
Blackbaud-BrandonJones Oct 10, 2017
d08f1b6
Merge branch 'master' into update-help-version
Blackbaud-BrandonJones Oct 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"@angular/platform-browser-dynamic": "4.3.6",
"@angular/router": "4.3.6",
"@blackbaud/auth-client": "1.16.0",
"@blackbaud/skyux-lib-help": "1.0.0",
"@blackbaud/skyux-lib-help": "1.0.1",
"@ngtools/webpack": "1.3.1",
"@types/core-js": "0.9.41",
"@types/fontfaceobserver": "0.0.5",
Expand Down
8 changes: 8 additions & 0 deletions src/app/app.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
.skyux-app-loading {
visibility: hidden;
}

/deep/
.sky-modal-body-full-page {
// Hide the bb-Help-invoker when a full-page modal is present and the widget is closed.
#bb-help-container.closed > #bb-help-invoker {
display: none;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Blackbaud-BobbyEarl What are your thoughts on adding an integration test for this behavior?
https://github.com/blackbaud/skyux-builder/tree/master/e2e

My thoughts: if we add a test, we could catch any selector changes from either the widget or UX.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree @Blackbaud-SteveBrush. I talked to @Blackbaud-BrandonJones. I'm comfortable getting this into builder right now due time constraints. He's added a task to his backlog to work on a test for this scenario, as well as a few other help related scenarios.

}
}