Update help version #293
Update help version #293
Conversation
…ally including patch level changes
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 59 59
Lines 1365 1365
Branches 206 206
=====================================
Hits 1365 1365
Continue to review full report at Codecov.
|
…nent when a full-page modal is involded
|
Putting this PR on-hold because it loosely depends on blackbaud/skyux2#1180. Once that is merged and released, we can come back to this. |
| .sky-modal-body-full-page { | ||
| // Hide the bb-Help-invoker when a full-page modal is present and the widget is closed. | ||
| #bb-help-container.closed > #bb-help-invoker { | ||
| display: none; |
There was a problem hiding this comment.
@Blackbaud-BobbyEarl What are your thoughts on adding an integration test for this behavior?
https://github.com/blackbaud/skyux-builder/tree/master/e2e
My thoughts: if we add a test, we could catch any selector changes from either the widget or UX.
There was a problem hiding this comment.
I agree @Blackbaud-SteveBrush. I talked to @Blackbaud-BrandonJones. I'm comfortable getting this into builder right now due time constraints. He's added a task to his backlog to work on a test for this scenario, as well as a few other help related scenarios.
Blackbaud-BrandonJones
changed the title
|
removing the |
Helps resolve this issue
blackbaud/skyux-lib-help#12
works in tandem with SKY UX 2 PR
blackbaud/skyux2#1180