Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin/fix-ci-and-upgrade-lint-dependencies #6

Merged
merged 1 commit into from
Jun 28, 2023
Merged

admin/fix-ci-and-upgrade-lint-dependencies #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,30 +2,30 @@ files: bioio
repos:

- repo: https://github.com/PyCQA/isort
rev: 5.10.1
rev: 5.12.0
hooks:
- id: isort

- repo: https://github.com/myint/autoflake
rev: v1.4
rev: v2.2.0
hooks:
- id: autoflake
args: ["--in-place", "--remove-all-unused-imports"]

- repo: https://github.com/psf/black
rev: 22.6.0
rev: 23.3.0
hooks:
- id: black

- repo: https://github.com/PyCQA/flake8
rev: 4.0.1
rev: 6.0.0
hooks:
- id: flake8
additional_dependencies:
- flake8-typing-imports>=1.9.0
- flake8-pyprojecttoml

- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.971
rev: v1.4.1
hooks:
- id: mypy
8 changes: 0 additions & 8 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,6 @@ Documentation = "https://bioio-devs.github.io/bioio"
# https://peps.python.org/pep-0621/#dependencies-optional-dependencies
[project.optional-dependencies]
lint = [
"black>=22.3.0",
"check-manifest>=0.48",
Copy link
Contributor Author

@SeanLeRoy SeanLeRoy Jun 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check-manifest wasn't being used in pre-commit like the others, instead it was installed without a specific version before just install was ran here so it seems safe to delete unless I am missing a usage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason I include black is that VSCode will auto format on save when it is installed.

(I may be wrong about that, that is how I have set it up anyway)

Check manifest can go. It's very useful but used infrequently.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, does VSCode not need any of these installed to have all the nice linting, formatting, type hinting, etc?

"flake8>=3.8.3",
"flake8-debugger>=3.2.1",
"flake8-pyprojecttoml",
"flake8-typing-imports>=1.9.0",
"isort>=5.7.0",
"mypy>=0.790",
"pre-commit>=2.20.0",
]
test = [
Expand Down