admin/fix-ci-and-upgrade-lint-dependencies #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanLeRoy
commented
Jun 27, 2023
| @@ -41,14 +41,6 @@ Documentation = "https://bioio-devs.github.io/bioio" | |||
| # https://peps.python.org/pep-0621/#dependencies-optional-dependencies | |||
| [project.optional-dependencies] | |||
| lint = [ | |||
| "black>=22.3.0", | |||
| "check-manifest>=0.48", | |||
There was a problem hiding this comment.
check-manifest wasn't being used in pre-commit like the others, instead it was installed without a specific version before just install was ran here so it seems safe to delete unless I am missing a usage.
There was a problem hiding this comment.
The only reason I include black is that VSCode will auto format on save when it is installed.
(I may be wrong about that, that is how I have set it up anyway)
Check manifest can go. It's very useful but used infrequently.
There was a problem hiding this comment.
Similarly, does VSCode not need any of these installed to have all the nice linting, formatting, type hinting, etc?
SeanLeRoy
changed the title
BrianWhitneyAI
approved these changes
Jun 27, 2023
toloudis
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The CI was failing due to an issue with
isortandpoetry, upgradingisortto>5.12.0fixes this issue. Beyond that I noticed the versions were specified in both.pre-commit-config.yaml&pyproject.toml, it doesn't appear thatpre-commitrequires any of these dependencies to be installed prior to runningpre-commitbased on it ignoring whatever version I specify inpyproject.tomland solely using the version specified by therevin thepre-commit-config.yaml. I tested this on MacOS as described below, but if I'm missing the value ofpyproject.tomlhaving the versions too let me know!Testing
Created a fresh virtual environment, installed dependencies, and ran
just lint&just test