feat(backend): allow pre eip-155 txs

cosmos/runtime/runtime.go

@@ -72,14 +72,12 @@ type CosmosApp interface {
 // It also includes wrapped versions of the Geth Miner and TxPool.
 type Polaris struct {
 	*eth.ExecutionLayer
-
 	// WrappedMiner is a wrapped version of the Miner component.
 	WrappedMiner *miner.Miner
 	// WrappedTxPool is a wrapped version of the Mempool component.
 	WrappedTxPool *txpool.Mempool
 	// WrappedBlockchain is a wrapped version of the Blockchain component.
 	WrappedBlockchain *chain.WrappedBlockchain
-
 	// logger is the underlying logger supplied by the sdk.
 	logger log.Logger
 }
@@ -97,7 +95,8 @@ func New(
 	}
 
 	p.ExecutionLayer, err = eth.New(
-		"geth", cfg, host, engine, LoggerFuncHandler(logger),
+		"geth", cfg, host, engine, cfg.Node.AllowUnprotectedTxs,
+		LoggerFuncHandler(logger),
 	)
 	if err != nil {
 		panic(err)

eth/eth.go

@@ -97,10 +97,10 @@ type (
 // as parameters. It returns a pointer to the ExecutionLayer and an error if any.
 func New(
 	client string, cfg any, host pcore.PolarisHostChain,
-	engine consensus.Engine, logHandler log.Handler,
+	engine consensus.Engine, allowUnprotectedTxs bool, logHandler log.Handler,
 ) (*ExecutionLayer, error) {
 	clientFactories := map[string]func(
-		any, pcore.PolarisHostChain, consensus.Engine, log.Handler,
+		any, pcore.PolarisHostChain, consensus.Engine, bool, log.Handler,
 	) (*ExecutionLayer, error){
 		"geth": newGethExecutionLayer,
 	}
@@ -110,14 +110,14 @@ func New(
 		return nil, fmt.Errorf("unknown execution layer: %s", client)
 	}
 
-	return factory(cfg, host, engine, logHandler)
+	return factory(cfg, host, engine, allowUnprotectedTxs, logHandler)
 }
 
 // newGethExecutionLayer creates a new geth execution layer.
 // It returns a pointer to the ExecutionLayer and an error if any.
 func newGethExecutionLayer(
 	anyCfg any, host pcore.PolarisHostChain,
-	engine consensus.Engine, logHandler log.Handler,
+	engine consensus.Engine, allowUnprotectedTxs bool, logHandler log.Handler,
 ) (*ExecutionLayer, error) {
 	cfg, ok := anyCfg.(*Config)
 	if !ok {
@@ -134,7 +134,7 @@ func newGethExecutionLayer(
 	gethNode.SetP2PDisabled(true)
 
 	// Create a new Polaris backend
-	backend := polar.New(&cfg.Polar, host, engine, gethNode, logHandler)
+	backend := polar.New(&cfg.Polar, host, engine, gethNode, allowUnprotectedTxs, logHandler)
 
 	// Return a new ExecutionLayer with the created gethNode and backend
 	return &ExecutionLayer{

eth/polar/api_backend.go

@@ -72,11 +72,12 @@ type (
 
 // backend represents the backend for the JSON-RPC service.
 type backend struct {
-	polar         *Polaris
-	cfg           *Config
-	extRPCEnabled bool
-	gpo           *gasprice.Oracle
-	logger        log.Logger
+	polar               *Polaris
+	cfg                 *Config
+	extRPCEnabled       bool
+	allowUnprotectedTxs bool
+	gpo                 *gasprice.Oracle
+	logger              log.Logger
 }
 
 // ==============================================================================
@@ -87,14 +88,16 @@ type backend struct {
 func NewAPIBackend(
 	polar *Polaris,
 	extRPCEnabled bool,
+	allowUnprotectedTxs bool,
 	cfg *Config,
 ) APIBackend {
 	b := &backend{
 
-		polar:         polar,
-		cfg:           cfg,
-		extRPCEnabled: extRPCEnabled,
-		logger:        log.Root(),
+		polar:               polar,
+		cfg:                 cfg,
+		extRPCEnabled:       extRPCEnabled,
+		allowUnprotectedTxs: allowUnprotectedTxs,
+		logger:              log.Root(),
 	}
 
 	if cfg.GPO.Default == nil {
@@ -173,10 +176,8 @@ func (b *backend) RPCTxFeeCap() float64 {
 }
 
 // UnprotectedAllowed returns whether unprotected transactions are alloweds.
-// We will consider implementing these later, But our opinion is that
-// there is no reason in 2023 not to use these.
 func (b *backend) UnprotectedAllowed() bool {
-	return false
+	return b.allowUnprotectedTxs
 }
 
 // ==============================================================================

eth/polar/backend.go

@@ -88,6 +88,7 @@ func New(
 	host core.PolarisHostChain,
 	engine consensus.Engine,
 	stack executionLayerNode,
+	allowUnprotectedTxs bool,
 	logHandler log.Handler,
 ) *Polaris {
 	// When creating a Polaris EVM, we allow the implementing chain
@@ -116,7 +117,7 @@ func New(
 	}
 
 	// Build the backend api object.
-	pl.apiBackend = NewAPIBackend(pl, stack.ExtRPCEnabled(), pl.config)
+	pl.apiBackend = NewAPIBackend(pl, stack.ExtRPCEnabled(), allowUnprotectedTxs, pl.config)
 
 	// Run safety message for feedback to the user if they are running
 	// with development configs.