feat(backend): allow pre eip-155 txs #1346
Conversation
WalkthroughThe recent updates across various components of the Cosmos ecosystem focus on enhancing telemetry and metrics collection. Time tracking and telemetry functions have been added to several key areas, including mining operations, transaction handling, and Ethereum Virtual Machine (EVM) processing. Additionally, there's a notable change in the configuration to allow unprotected transactions, reflecting a shift in how transactions are managed and secured. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
itsdevbear
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
itsdevbear
added
merge me daddy
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## telemetry #1346 +/- ##
==========================================
Coverage 48.63% 48.63%
==========================================
Files 84 84
Lines 4914 4914
==========================================
Hits 2390 2390
Misses 2347 2347
Partials 177 177 |
## Summary by CodeRabbit - **New Features** - Introduced telemetry tracking for mining metrics, mempool status, and transaction broadcast outcomes. - Enabled configuration for allowing unprotected transactions in the system. - **Improvements** - Enhanced system performance monitoring with new telemetry constants and time recording. - **Documentation** - Added SPDX license headers across various files for compliance with licensing requirements. - **Bug Fixes** - Removed an unnecessary flag from the startup command in the test application. - **Refactor** - Streamlined telemetry code by introducing new constants and deferred calls for better maintainability. - **Configuration** - Adjusted application configuration to enable telemetry by default. (cherry picked from commit c53168f)
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- eth/eth.go (3 hunks)
Additional comments: 3
eth/eth.go (3)
97-104: The addition of the
allowUnprotectedTxsparameter to theNewfunction is consistent with the PR's objective to process pre-EIP-155 transactions. Ensure that the parameter is well-documented and that its usage is consistent throughout the codebase.116-123: The
newGethExecutionLayerfunction now correctly includes theallowUnprotectedTxsparameter, which is necessary for the backend to handle pre-EIP-155 transactions. Ensure that this parameter is being handled correctly within the function.134-137: The
polar.Newfunction is invoked with theallowUnprotectedTxsparameter. Verify that thepolar.Newfunction has been updated to accept this new parameter and that it is correctly handled within thepolarpackage.
| // as parameters. It returns a pointer to the ExecutionLayer and an error if any. | ||
| func New( | ||
| client string, cfg any, host pcore.PolarisHostChain, | ||
| engine consensus.Engine, logHandler log.Handler, | ||
| engine consensus.Engine, allowUnprotectedTxs bool, logHandler log.Handler, |
There was a problem hiding this comment.
The allowUnprotectedTxs parameter has been added to the New function without accompanying documentation or comments. It is important to document new parameters to explain their purpose and usage for future maintainability and clarity.
client string, cfg any, host pcore.PolarisHostChain,
+ // allowUnprotectedTxs enables the processing of transactions without EIP-155 protection.
engine consensus.Engine, allowUnprotectedTxs bool, logHandler log.Handler,Committable suggestion
❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| // as parameters. It returns a pointer to the ExecutionLayer and an error if any. | |
| func New( | |
| client string, cfg any, host pcore.PolarisHostChain, | |
| engine consensus.Engine, logHandler log.Handler, | |
| engine consensus.Engine, allowUnprotectedTxs bool, logHandler log.Handler, | |
| // as parameters. It returns a pointer to the ExecutionLayer and an error if any. | |
| func New( | |
| client string, cfg any, host pcore.PolarisHostChain, | |
| // allowUnprotectedTxs enables the processing of transactions without EIP-155 protection. | |
| engine consensus.Engine, allowUnprotectedTxs bool, logHandler log.Handler, |
This is an automatic backport of pull request #1346 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Devon Bear <itsdevbear@berachain.com>
|
This pr has not been deployed to the private testnet. Please use the dedicated repo to report issues as to not leak rpc information online. thanks! |
I added you as a contributor to the repo. You should have received a notification about it. Please confirm. |
Summary by CodeRabbit
New Features
Improvements
Documentation
Bug Fixes
Refactor
Configuration