Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/form field additions #132

Merged
merged 21 commits into from
Apr 18, 2019
Merged

Feature/form field additions #132

merged 21 commits into from
Apr 18, 2019

Conversation

Jonesy
Copy link
Contributor

@Jonesy Jonesy commented Apr 17, 2019

Description

Includes integration tests fixes, updated form fields based off of Output Documentation and a fix for phantom file uploads

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change with enhancements to documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Jonesy and others added 21 commits April 11, 2019 11:38
@Jonesy
Update UI to use revised request fields, with better validation. Also…
ca37713 
… remove new request from download UI.
@Jonesy
Add phoneNumber and subPopulation support to the API, clean up so…
b5f29f5 
…me validation.
@pripley123
fix for req fields
68fe13c
@pripley123
fixed xpath for textboxes
637182d
@pripley123
fix textarea xpath
81ab980
@pripley123
fix util func
370ac25
@pripley123
fix submit alert issue
98c3193
@pripley123
added wait for page load
05e3e67
@pripley123
added wait to submit alert
309574f
@pripley123
fix alert wait issue
d4e43bc
@Jonesy
Remove submit confirm so tests will pass for now.
ce29cc6
@Jonesy
Update nyc and some frontend packages to pass npm audit.
65df1ab
@pripley123
add request state check after submission
b8b635c
@pripley123
add submit error msg check
5e893ab
@pripley123
add screenshot cap on error
a378ccc
@pripley123
fail instead of error for err msg
6db2c7a
@pripley123
increase time for validation
c526941
@pripley123
add wait for validation
7c20c22
@pripley123
fix wait for success alert
c894bd9
@pripley123
more time for file validation
442fd88
@Jonesy
Reset form and uploads when editing is complete, remove phantom values.
8cd5f0a
@Jonesy Jonesy requested a review from BrandonSharratt April 17, 2019 20:42
BrandonSharratt
BrandonSharratt approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@BrandonSharratt BrandonSharratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@BrandonSharratt BrandonSharratt merged commit 0bedd6d into develop Apr 18, 2019
This was referenced Apr 18, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@bdolor bdolor deleted the feature/form-field-additions branch November 26, 2019 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonSharratt BrandonSharratt BrandonSharratt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jonesy @BrandonSharratt @pripley123