Update repositories.bzl #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to recent changes, the repository now requires skylib and zlib.
|
LGTM except the failing test. |
|
Fixed the tests, updated the description. |
gkdn
approved these changes
Apr 26, 2019
lucamilanesio
pushed a commit
to GerritCodeReview/gerrit
that referenced
this pull request
May 10, 2019
The latest rules closure version exposed zlib dependency in its own repository.bzl file, so that we can remove it from the build tool chain: [1]. We also have to omit bazel_skylib fetching, because this dependency already fetched in WORKSPACE for minimum supported version checking. [1] bazelbuild/rules_closure#363 Change-Id: I9e2a695594a3e9b857be8f7fca4359f5c3a4b88d
ptmphuong
pushed a commit
to ptmphuong/rules_closure
that referenced
this pull request
Dec 9, 2022
The repository now requires skylib and zlib, since the Protobuf update (bazelbuild#341, bazelbuild#344).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repository now requires skylib and zlib, since the Protobuf update (#341, #344).