Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf version to 3.7.1 #344

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

davido
Copy link
Contributor

@davido davido commented Mar 26, 2019

In: [1] the prerequisites were added to rules_closure for protobuf
upgrade to the version 3.7.0:

  • Dependency on bazel_skylib
  • Dependency on zlib

In this change the protobuf version is updated to 3.7.1.

[1] #341

@davido
Copy link
Contributor Author

davido commented Mar 26, 2019

Can someone please upload: https://mirror.bazel.build/github.com/google/protobuf/archive/v3.7.1.tar.gz? Thanks.

Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for all these updates!

In: [1] the prerequisites were added to rules_closure for protobuf
upgrade to the version 3.7.0:

* Dependency on bazel_skylib
* Dependency on zlib

In this change the protobuf version is updated to 3.7.1.

[1] bazelbuild#341
@laurentlb laurentlb merged commit 08e5bc3 into bazelbuild:master Mar 27, 2019
@davido davido deleted the update_protobuf_to_3.7.1 branch March 27, 2019 20:02
laurentlb added a commit that referenced this pull request Apr 26, 2019
The repository now requires skylib and zlib, since the Protobuf update (#341, #344).
ptmphuong pushed a commit to ptmphuong/rules_closure that referenced this pull request Dec 9, 2022
In: [1] the prerequisites were added to rules_closure for protobuf
upgrade to the version 3.7.0:

* Dependency on bazel_skylib
* Dependency on zlib

In this change the protobuf version is updated to 3.7.1.

[1] bazelbuild#341
ptmphuong pushed a commit to ptmphuong/rules_closure that referenced this pull request Dec 9, 2022
The repository now requires skylib and zlib, since the Protobuf update (bazelbuild#341, bazelbuild#344).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants