Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #761

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Revert #761

merged 2 commits into from
Jan 18, 2023

Conversation

TerryHowe
Copy link
Contributor

No description provided.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TerryHowe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2023
@ivyostosh
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit 360d299 into aws:main Jan 18, 2023
ewollesen pushed a commit to ewollesen/eks-anywhere-packages that referenced this pull request Jan 18, 2023
This reverts commit 360d299.

The reversion of de9c0be (by 360d299) was performed due to what was believed
to be a regression, but was later found to be a config issue.

Since 360d299 squashed both the revert, plus another small change into one
commit, this revert will undo both. That is, it re-instates de9c0be, and
reverts the small change squashed into the original revert. (Clear as mud,
right?)

A follow up commit will manually re-instate the small change.
eks-distro-bot pushed a commit that referenced this pull request Jan 19, 2023
This reverts commit 360d299.

The reversion of de9c0be (by 360d299) was performed due to what was believed
to be a regression, but was later found to be a config issue.

Since 360d299 squashed both the revert, plus another small change into one
commit, this revert will undo both. That is, it re-instates de9c0be, and
reverts the small change squashed into the original revert. (Clear as mud,
right?)

A follow up commit will manually re-instate the small change.
@TerryHowe TerryHowe deleted the revert branch January 24, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants