Lift configfile #757
Merged
Lift configfile #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 17, 2023 16:49
There's no point in storing it, as it's never reused.
Rather than assuming that users of CredentialStore will know to call Init after instantiation, the CredentialStore's dependency on a Docker *ConfigFile is made explicit by requiring it to be passed to the constructor. Now we need never worry that a user will forget to call Init, and it removes the awkward pattern of New-then-Init.
eks-distro-bot
added
approved
size/L
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewollesen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
|
/lgtm Looks like a good refactor |
TerryHowe
reviewed
Jan 18, 2023
| // CredentialStore for registry credentials such as ~/.docker/config.json. | ||
| type CredentialStore struct { | ||
| directory string | ||
| // DockerCredentialStore for Docker registry credentials, like ~/.docker/config.json. |
There was a problem hiding this comment.
This is all fine, but I don't like docker in the name. I was trying to hide that. We don't have to be stuck with docker forever.
|
We may want to revisit this PR as bundle pulling failed due to 401 unauthorized access. |
TerryHowe
pushed a commit
to TerryHowe/eks-anywhere-packages
that referenced
this pull request
Jan 18, 2023
This reverts commit de9c0be.
eks-distro-bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two smallish changes:
and: