Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make maxPendingRequests optional and disable preview aws-sdk-go #383

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Make maxPendingRequests optional and disable preview aws-sdk-go #383

merged 2 commits into from
Nov 6, 2020

Conversation

fawadkhaliq
Copy link

@fawadkhaliq fawadkhaliq commented Nov 5, 2020

Issue #372

Description of changes
maxPendingRequests configuration for HTTP connection pool setting has been marked as an optional param in AWS App Mesh. This changes makes maxPendingRequests optional in CRDs

  • Marked maxPendingRequests as optional
  • Changed the aws-sdk-go to the GA version and disabled preview builds
  • Enabled integration tests for virtual node and virtual gateway
  • Integration test update scenarios were flaky. There was a race in how update resource was chosen. Fixed the race by using the correct resource object in update scenarios

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@fawadkhaliq fawadkhaliq marked this pull request as draft November 5, 2020 21:46
@fawadkhaliq fawadkhaliq requested a review from achevuru November 6, 2020 03:15
@fawadkhaliq fawadkhaliq marked this pull request as ready for review November 6, 2020 03:15
@fawadkhaliq fawadkhaliq merged commit 02c77e8 into aws:master Nov 6, 2020
@fawadkhaliq fawadkhaliq deleted the optional-maxpenreqs branch November 6, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants