Replace provider with typescript client for querying prometheus data #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 29, 2023 16:45
Merged
arendjr
approved these changes
Jul 31, 2023
| "*.json" | ||
| ] | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
What you did to my newline? :p
There was a problem hiding this comment.
it was just on vacation it's coming back
| * At first, I needed to copy it here to fix an issue with the url. | ||
| * But then I realized that we would need to polyfill fetch to use it, | ||
| * so I think we'll just keep this version here for now, and | ||
| * rely on the utilities to transform the request/response into the format we need. |
There was a problem hiding this comment.
I think it might be a nice solution to add this to fiberplane-prometheus-query instead:
export type QueryPrometheusOptions = RequestInit & {
/**
* Base URL to the Prometheus service, without trailing slash.
*/
baseUrl: string;
/**
* Custom `fetch` function to use instead of the global `fetch`.
*
* May be used to support environments that don't support `fetch`, or to inject `fetch` during tests.
*/
fetch?: typeof fetch;
};There was a problem hiding this comment.
yeah agreed — i was a little hesitant in this case because node-fetch is subtly different than browser fetch (e.g., it doesn't accept a cors parameter, but i don't think typescript would complain about that)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps out the
prometheus.tsfile, removes the provider runtime, and addsfiberplane-prometheus-queryas a dependency.The
Prometheusclient exported byprometheus.tsstill exposes the same interface, so there weren't many changes outside of that file.Motivation for this PR was that the provider didn't seem to like using the URL
http://localhost:9090/prometheus, i.e., the path to prometheus data exposed byam.I tested locally, but would appreciate a second set of eyes.