Prepare release of 0.5.0 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think we're ready to merge and release! |
flenter
approved these changes
Aug 14, 2023
| @@ -81,6 +81,9 @@ export const TypescriptHover = { | |||
| } | |||
| return undefined; | |||
| } catch (err) { | |||
| // NOTE - This could happen because of an error in other TS plugins | |||
| // I.e., we could end up propagating errors from other plugins | |||
| // (This happened to me with the tailwind intellisense plugin) | |||
There was a problem hiding this comment.
I was thinking: Is there a way where we can better expose the exact error the user?
It seems like we can't show multiline notifications (see microsoft/vscode#101589) but perhaps we could do something where we add a "details" button so the user can find out more information around the exact error (which might help us resolve issues faster)
The @autometrics/typescript-plugin. This is done just be make sure that people use the (current) latest release of the typescript plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
I hit a few issues when doing a QA pass over the course of a few days:
Clicking on a function in the Autometrics side bar will open a new tab for that function, but the graphs won't appear (Clicking on a function in the Autometrics side bar does not show full graphs page #62)
Typescript tooltips broke for me in another project (fiberplane-charts) — the Autometrics extension threw an error, even in a project that did not have autometrics, so, the tooltips for a general typescript type just would not appear. (Noted this in an issue, as the culprit was another extension: 🐛 Errors from other Typescript extensions can cause Autometrics to show a toast error notification #63)
Latency queries did not work with my sample Python app (fixed in Support renamed metrics (and fix build_info queries) #61)
Integrated charts throw an error when fetching data from
amprometheus (fixed in Replace provider with typescript client for querying prometheus data #60)