Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle all external assets (/wo twemoji) #1785

Merged
merged 1 commit into from
May 1, 2022
Merged

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented May 1, 2022

replace & repush of #1782, no twemoji icons (reduce repo size by about 3500 files / 25 MB)

other resources are carefully selected (like we do not need to bundle other fonts than WOFF2)

fixes #1025

external Google Fonts will be bundled in a separate PR (#1784)

temporary, App::cdn paths must be adjusted! - public URL discovery will be added in a separate PR

example temporary fix of your app to be put to the code where you create/init your App instance:

foreach ($app->cdn as $k => $v) {
    $app->cdn[$k] = '/xxx/vendor/atk4/ui' . $v;
}

@mvorisek mvorisek added the MAJOR label May 1, 2022
@mvorisek mvorisek force-pushed the reduce_bundle_file_count branch from 36d565e to dfde81b Compare May 1, 2022 14:44
@mvorisek mvorisek force-pushed the reduce_bundle_file_count branch from dfde81b to dac3f64 Compare May 1, 2022 14:49
@mvorisek mvorisek marked this pull request as ready for review May 1, 2022 15:22
@mvorisek mvorisek force-pushed the reduce_bundle_file_count branch from 8f3318b to a1c08b4 Compare May 1, 2022 15:36
@mvorisek mvorisek merged commit a1a8a28 into develop May 1, 2022
@mvorisek mvorisek deleted the reduce_bundle_file_count branch May 1, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Use local resources only - pack/download from CDN lately on install
1 participant